Fix missingType.return errors

Author: warcooft

system/Session/Session.php

@@ -268,7 +268,7 @@ public function start()
      *
      * @deprecated Use destroy() instead.
      */
-    public function stop()
+    public function stop(): void
     {
         $this->destroy();
     }
@@ -278,7 +278,7 @@ public function stop()
      *
      * Handle input binds and configuration defaults.
      */
-    protected function configure()
+    protected function configure(): void
     {
         ini_set('session.name', $this->config->cookieName);
 
@@ -319,7 +319,7 @@ protected function configure()
      * To make life easier, we force the PHP defaults. Because PHP9 forces them.
      * See https://wiki.php.net/rfc/deprecations_php_8_4#sessionsid_length_and_sessionsid_bits_per_character
      */
-    protected function configureSidLength()
+    protected function configureSidLength(): void
     {
         $bitsPerCharacter = (int) ini_get('session.sid_bits_per_character');
         $sidLength        = (int) ini_get('session.sid_length');
@@ -343,7 +343,7 @@ protected function configureSidLength()
      * Clears old "flash" data, marks the new one for deletion and handles
      * "temp" data deletion.
      */
-    protected function initVars()
+    protected function initVars(): void
     {
         if (! isset($_SESSION['__ci_vars'])) {
             return;
@@ -371,7 +371,7 @@ protected function initVars()
      *
      * @param bool $destroy Should old session data be destroyed?
      */
-    public function regenerate(bool $destroy = false)
+    public function regenerate(bool $destroy = false): void
     {
         $_SESSION['__ci_last_regenerate'] = Time::now()->getTimestamp();
         session_regenerate_id($destroy);
@@ -402,7 +402,7 @@ private function removeOldSessionCookie(): void
     /**
      * Destroys the current session.
      */
-    public function destroy()
+    public function destroy(): void
     {
         if (ENVIRONMENT === 'testing') {
             return;
@@ -437,7 +437,7 @@ public function close()
      * @param array|string                            $data  Property name or associative array of properties
      * @param array|bool|float|int|object|string|null $value Property value if single key provided
      */
-    public function set($data, $value = null)
+    public function set($data, $value = null): void
     {
         if (is_array($data)) {
             foreach ($data as $key => &$value) {
@@ -511,7 +511,7 @@ public function has(string $key): bool
      * @param string $key  Identifier of the session property we are interested in.
      * @param array  $data value to be pushed to existing session key.
      */
-    public function push(string $key, array $data)
+    public function push(string $key, array $data): void
     {
         if ($this->has($key) && is_array($value = $this->get($key))) {
             $this->set($key, array_merge($value, $data));
@@ -527,7 +527,7 @@ public function push(string $key, array $data)
      *
      * @param array|string $key Identifier of the session property or properties to remove.
      */
-    public function remove($key)
+    public function remove($key): void
     {
         if (is_array($key)) {
             foreach ($key as $k) {
@@ -599,7 +599,7 @@ public function __isset(string $key): bool
      * @param array|string                            $data  Property identifier or associative array of properties
      * @param array|bool|float|int|object|string|null $value Property value if $data is a scalar
      */
-    public function setFlashdata($data, $value = null)
+    public function setFlashdata($data, $value = null): void
     {
         $this->set($data, $value);
         $this->markAsFlashdata(is_array($data) ? array_keys($data) : $data);
@@ -639,7 +639,7 @@ public function getFlashdata(?string $key = null)
      *
      * @param array|string $key Property identifier or array of them
      */
-    public function keepFlashdata($key)
+    public function keepFlashdata($key): void
     {
         $this->markAsFlashdata($key);
     }
@@ -681,7 +681,7 @@ public function markAsFlashdata($key): bool
      *
      * @param array|string $key Property identifier or array of them
      */
-    public function unmarkFlashdata($key)
+    public function unmarkFlashdata($key): void
     {
         if (! isset($_SESSION['__ci_vars'])) {
             return;
@@ -732,7 +732,7 @@ public function getFlashKeys(): array
      * @param array|bool|float|int|object|string|null $value Value to store
      * @param int                                     $ttl   Time-to-live in seconds
      */
-    public function setTempdata($data, $value = null, int $ttl = 300)
+    public function setTempdata($data, $value = null, int $ttl = 300): void
     {
         $this->set($data, $value);
         $this->markAsTempdata($data, $ttl);
@@ -771,7 +771,7 @@ public function getTempdata(?string $key = null)
      *
      * @param string $key Session data key
      */
-    public function removeTempdata(string $key)
+    public function removeTempdata(string $key): void
     {
         $this->unmarkTempdata($key);
         unset($_SESSION[$key]);
@@ -831,7 +831,7 @@ public function markAsTempdata($key, int $ttl = 300): bool
      *
      * @param array|string $key Property identifier or array of them
      */
-    public function unmarkTempdata($key)
+    public function unmarkTempdata($key): void
     {
         if (! isset($_SESSION['__ci_vars'])) {
             return;
@@ -876,7 +876,7 @@ public function getTempKeys(): array
      * Sets the driver as the session handler in PHP.
      * Extracted for easier testing.
      */
-    protected function setSaveHandler()
+    protected function setSaveHandler(): void
     {
         session_set_save_handler($this->driver, true);
     }
@@ -885,7 +885,7 @@ protected function setSaveHandler()
      * Starts the session.
      * Extracted for testing reasons.
      */
-    protected function startSession()
+    protected function startSession(): void
     {
         if (ENVIRONMENT === 'testing') {
             $_SESSION = [];
@@ -901,7 +901,7 @@ protected function startSession()
      *
      * @codeCoverageIgnore
      */
-    protected function setCookie()
+    protected function setCookie(): void
     {
         $expiration   = $this->config->expiration === 0 ? 0 : Time::now()->getTimestamp() + $this->config->expiration;
         $this->cookie = $this->cookie->withValue(session_id())->withExpires($expiration);