fix missing notifications issue#52
Merged
Merged
Conversation
harryalbert
force-pushed
the
harry/fix-missing-notifications
branch
from
3991cfe to
0d0726e
Compare
harryalbert
commented
May 18, 2026
| } | ||
|
|
||
| # Returns 0 if the running Claude Code version supports terminalSequence. | ||
| _supports_terminal_sequence() { |
Contributor
Author
There was a problem hiding this comment.
Some hooks (but not others for some reason) error out when you include unexpected fields , so we need to check the claude code version to see whether this field is supported before emitting it
| INPUT=$(cat) | ||
|
|
||
| # Best-effort Claude Code version detection. | ||
| # Cache in $CLAUDE_ENV_FILE so subsequent hooks can skip the lookup, and |
Contributor
Author
There was a problem hiding this comment.
I was very surprised to find that claude code doesn't include an easy way for plugins to check the installed claude code version, so we need to do this check/cache the env variable manually
There was a problem hiding this comment.
Oof, that's annoying and indeed surprising
3 tasks
liliwilson
approved these changes
May 18, 2026
| INPUT=$(cat) | ||
|
|
||
| # Best-effort Claude Code version detection. | ||
| # Cache in $CLAUDE_ENV_FILE so subsequent hooks can skip the lookup, and |
There was a problem hiding this comment.
Oof, that's annoying and indeed surprising
harryalbert
added a commit
to warpdotdev/warp
that referenced
this pull request
May 18, 2026
## Description <!-- Please remember to add your design buddy onto the PR for review, if it contains any UI changes! --> There was a bug caused by a claude code release that made it so our plugin could no longer emit OSC 777 events, breaking notifications. Claude code released a fix for this with a new notifications field, which we leverage in this PR: warpdotdev/claude-code-warp#52. We should encourage folks to download the new plugin so that notifications are fixed for them. ## Linked Issue <!-- Link the GitHub issue this PR addresses. Before opening this PR, please confirm: --> - [x] Where appropriate, screenshots or a short video of the implementation are included below (especially for user-visible or UI changes). Fixes #10715. ## Testing <!-- How did you test this change? What automated tests did you add? If you didn't add any new tests, what's your justification for not adding any? Manual testing is required for changes that can be manually tested, and almost all changes can be manually tested. If your change can be manually tested, please include screenshots or a screen recording that show it working end to end. You can run the app locally using `./script/run` - see WARP.md for more details on how to get set up. --> - [x] I have manually tested my changes locally with `./script/run` ### Screenshots / Videos <!-- Attach screenshots or a short video demonstrating the change, where appropriate. Remove this section if it is not relevant to your PR. --> https://www.loom.com/share/d81b295807544269b57eb8d811575b28 ## Agent Mode - [x] Warp Agent Mode - This PR was created via Warp's AI Agent Mode <!-- ## Changelog Entries for Stable The entries below will be used when constructing a soft-copy of the stable release changelog. Leave blank or remove the lines if no entry in the stable changelog is needed. Entries should be on the same line, without the `{{` `}}` brackets. You can use multiple lines, even of the same type. The valid suffixes are: - NEW-FEATURE: for new, relatively sizable features. Features listed here will likely have docs / social media posts / marketing launches associated with them, so use sparingly. - IMPROVEMENT: for new functionality of existing features. - BUG-FIX: for fixes related to known bugs or regressions. - IMAGE: the image specified by the URL (hosted on GCP) will be added to Dev & Preview releases. For Stable releases, see the pinned doc in the #release Slack channel. - OZ: Oz-related updates. Use `CHANGELOG-OZ`. At most 4 Oz updates are shown in-app per release. - NONE: Explicitly opt out of changelog inclusion. Use `CHANGELOG-NONE` for PRs that should never appear in the changelog (e.g. refactors, internal tooling, CI changes). This prevents the changelog agent from inferring an entry. CHANGELOG-NEW-FEATURE: {{text goes here...}} CHANGELOG-IMPROVEMENT: {{text goes here...}} CHANGELOG-BUG-FIX: Fixed rich claude code notifications (with new plugin version) CHANGELOG-BUG-FIX: {{more text goes here...}} CHANGELOG-IMAGE: {{GCP-hosted URL goes here...}} CHANGELOG-OZ: {{text goes here...}} CHANGELOG-NONE -->
stupidloud
pushed a commit
to stupidloud/warp-cn
that referenced
this pull request
May 21, 2026
## Description <!-- Please remember to add your design buddy onto the PR for review, if it contains any UI changes! --> There was a bug caused by a claude code release that made it so our plugin could no longer emit OSC 777 events, breaking notifications. Claude code released a fix for this with a new notifications field, which we leverage in this PR: warpdotdev/claude-code-warp#52. We should encourage folks to download the new plugin so that notifications are fixed for them. ## Linked Issue <!-- Link the GitHub issue this PR addresses. Before opening this PR, please confirm: --> - [x] Where appropriate, screenshots or a short video of the implementation are included below (especially for user-visible or UI changes). Fixes warpdotdev/warp#10715. ## Testing <!-- How did you test this change? What automated tests did you add? If you didn't add any new tests, what's your justification for not adding any? Manual testing is required for changes that can be manually tested, and almost all changes can be manually tested. If your change can be manually tested, please include screenshots or a screen recording that show it working end to end. You can run the app locally using `./script/run` - see WARP.md for more details on how to get set up. --> - [x] I have manually tested my changes locally with `./script/run` ### Screenshots / Videos <!-- Attach screenshots or a short video demonstrating the change, where appropriate. Remove this section if it is not relevant to your PR. --> https://www.loom.com/share/d81b295807544269b57eb8d811575b28 ## Agent Mode - [x] Warp Agent Mode - This PR was created via Warp's AI Agent Mode <!-- ## Changelog Entries for Stable The entries below will be used when constructing a soft-copy of the stable release changelog. Leave blank or remove the lines if no entry in the stable changelog is needed. Entries should be on the same line, without the `{{` `}}` brackets. You can use multiple lines, even of the same type. The valid suffixes are: - NEW-FEATURE: for new, relatively sizable features. Features listed here will likely have docs / social media posts / marketing launches associated with them, so use sparingly. - IMPROVEMENT: for new functionality of existing features. - BUG-FIX: for fixes related to known bugs or regressions. - IMAGE: the image specified by the URL (hosted on GCP) will be added to Dev & Preview releases. For Stable releases, see the pinned doc in the #release Slack channel. - OZ: Oz-related updates. Use `CHANGELOG-OZ`. At most 4 Oz updates are shown in-app per release. - NONE: Explicitly opt out of changelog inclusion. Use `CHANGELOG-NONE` for PRs that should never appear in the changelog (e.g. refactors, internal tooling, CI changes). This prevents the changelog agent from inferring an entry. CHANGELOG-NEW-FEATURE: {{text goes here...}} CHANGELOG-IMPROVEMENT: {{text goes here...}} CHANGELOG-BUG-FIX: Fixed rich claude code notifications (with new plugin version) CHANGELOG-BUG-FIX: {{more text goes here...}} CHANGELOG-IMAGE: {{GCP-hosted URL goes here...}} CHANGELOG-OZ: {{text goes here...}} CHANGELOG-NONE -->
lawsmd
pushed a commit
to lawsmd/cortex
that referenced
this pull request
May 22, 2026
…11204) ## Description <!-- Please remember to add your design buddy onto the PR for review, if it contains any UI changes! --> There was a bug caused by a claude code release that made it so our plugin could no longer emit OSC 777 events, breaking notifications. Claude code released a fix for this with a new notifications field, which we leverage in this PR: warpdotdev/claude-code-warp#52. We should encourage folks to download the new plugin so that notifications are fixed for them. ## Linked Issue <!-- Link the GitHub issue this PR addresses. Before opening this PR, please confirm: --> - [x] Where appropriate, screenshots or a short video of the implementation are included below (especially for user-visible or UI changes). Fixes warpdotdev#10715. ## Testing <!-- How did you test this change? What automated tests did you add? If you didn't add any new tests, what's your justification for not adding any? Manual testing is required for changes that can be manually tested, and almost all changes can be manually tested. If your change can be manually tested, please include screenshots or a screen recording that show it working end to end. You can run the app locally using `./script/run` - see WARP.md for more details on how to get set up. --> - [x] I have manually tested my changes locally with `./script/run` ### Screenshots / Videos <!-- Attach screenshots or a short video demonstrating the change, where appropriate. Remove this section if it is not relevant to your PR. --> https://www.loom.com/share/d81b295807544269b57eb8d811575b28 ## Agent Mode - [x] Warp Agent Mode - This PR was created via Warp's AI Agent Mode <!-- ## Changelog Entries for Stable The entries below will be used when constructing a soft-copy of the stable release changelog. Leave blank or remove the lines if no entry in the stable changelog is needed. Entries should be on the same line, without the `{{` `}}` brackets. You can use multiple lines, even of the same type. The valid suffixes are: - NEW-FEATURE: for new, relatively sizable features. Features listed here will likely have docs / social media posts / marketing launches associated with them, so use sparingly. - IMPROVEMENT: for new functionality of existing features. - BUG-FIX: for fixes related to known bugs or regressions. - IMAGE: the image specified by the URL (hosted on GCP) will be added to Dev & Preview releases. For Stable releases, see the pinned doc in the #release Slack channel. - OZ: Oz-related updates. Use `CHANGELOG-OZ`. At most 4 Oz updates are shown in-app per release. - NONE: Explicitly opt out of changelog inclusion. Use `CHANGELOG-NONE` for PRs that should never appear in the changelog (e.g. refactors, internal tooling, CI changes). This prevents the changelog agent from inferring an entry. CHANGELOG-NEW-FEATURE: {{text goes here...}} CHANGELOG-IMPROVEMENT: {{text goes here...}} CHANGELOG-BUG-FIX: Fixed rich claude code notifications (with new plugin version) CHANGELOG-BUG-FIX: {{more text goes here...}} CHANGELOG-IMAGE: {{GCP-hosted URL goes here...}} CHANGELOG-OZ: {{text goes here...}} CHANGELOG-NONE -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Claude code released a new version that prevented plugins interacting with the terminal. This borked our plugin on newer versions of claude code, as it needs terminal access to emit OSC 777 notifications.
To fix this, the claude code team released a new field,
terminalSequence, that we can use to emit our notifications. This field is only present on newer versions of claude code (and some hooks error out when you include unkown fields), so we need to conditionally include this field when the claude code version is new enough to support itDemo
https://www.loom.com/share/d81b295807544269b57eb8d811575b28