fix(warp): run hook scripts through bash on Windows#57
Open
0okay wants to merge 1 commit into
Open
Conversation
Claude Code native Windows 直接执行 .sh hook 时会触发系统的选择应用打开弹窗。 将 hooks.json 中的脚本命令改为显式 bash 调用，避免 Windows ShellExecute 处理 .sh 文件。 影响范围：plugins/warp/hooks/hooks.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bashinhooks.json.shfiles when hooks runCloses #56
Verification
Get-Content -Raw plugins\warp\hooks\hooks.json | ConvertFrom-Json | Out-Nullgit diff --checkon-post-tool-use.shinvocation through Bash exits successfully in local Windows environmentNote:
bash plugins/warp/tests/test-hooks.shcurrently reports 55 passed / 2 failed on Windows Git Bash because test fixture paths like/Users/alice/my-projectand/tmp/transcript.jsonlare auto-converted toC:/Program Files/Git/...andC:/Users/Administrator/AppData/Local/Temp/.... Those failures appear unrelated to this hook command change.