Skip to content

Add pass (password-store) entry completion generator#215

Closed
lucieleblanc wants to merge 1 commit into
mainfrom
oz-agent/APP-3516/add-pass-entry-completion
Closed

Add pass (password-store) entry completion generator#215
lucieleblanc wants to merge 1 commit into
mainfrom
oz-agent/APP-3516/add-pass-entry-completion

Conversation

@lucieleblanc
Copy link
Copy Markdown
Contributor

Summary

Add a Rust generator for the pass (password-store) command so that pass <TAB> lists entries from ~/.password-store (or $PASSWORD_STORE_DIR).

The existing pass.json spec had JavaScript script/postProcess generators inherited from the Fig import, which are ignored by Warp. This PR replaces them with generatorName references to new Rust-based generators.

Changes

New file: command-signatures/src/generators/pass.rs

  • entries generator: runs find in the password store directory to list .gpg files, strips the extension via sed, and returns them as "Password entry" suggestions
  • directories generator: runs find to list subdirectories, returning them as "Password directory" suggestions for the ls/list subcommand
  • Both respect $PASSWORD_STORE_DIR (falling back to $HOME/.password-store)

Modified: command-signatures/src/generators/mod.rs

  • Registered the new pass module and generator

Modified: command-signatures/json/pass.json

  • Replaced all JavaScript generators objects with generatorName references:
    • Top-level pass, show, edit, cp, mv, rm"generatorName": "entries"
    • ls/list"generatorName": "directories"

Testing

All 21 existing tests pass, including all_referenced_generators_exist and all_command_specs_succeed_deserialization which validate that every generatorName in JSON specs maps to a registered Rust generator.

Fixes: warpdotdev/warp#2067


Conversation: https://staging.warp.dev/conversation/b5ad1bb5-f9dc-4d6e-a2c2-30e1d2af5abb
Run: https://oz.staging.warp.dev/runs/019d49b6-ab3b-7b18-b13e-c56c3c4c5f13

This PR was generated with Oz.

Add a Rust generator for the pass command that lists entries and
directories from the password store (~/.password-store or
$PASSWORD_STORE_DIR). Replace the JavaScript script/postProcess
generators in pass.json with generatorName references to the new
Rust generators.

Two generators are provided:
- entries: lists .gpg files (password entries) with the .gpg
  extension stripped
- directories: lists subdirectories for the ls/list subcommand

Fixes: warpdotdev/warp#2067

Co-Authored-By: Oz <oz-agent@warp.dev>
@linear
Copy link
Copy Markdown

linear Bot commented Apr 1, 2026

APP-3516 Add pass (password-store) entry completion

pass.json spec exists but has no Rust generator. pass <TAB> should list entries from ~/.password-store directory tree.

See GitHub #2067

@lucieleblanc
Copy link
Copy Markdown
Contributor Author

Closing since no UI verification was done; will retry when skills are being correctly loaded.

@lucieleblanc lucieleblanc deleted the oz-agent/APP-3516/add-pass-entry-completion branch April 1, 2026 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for pass(https://www.passwordstore.org/) autocomplete.

2 participants