Add completion spec: pass (password-store)#221
Merged
Conversation
Replace Fig-style JavaScript generators in pass.json with Rust-based generators that list password entries and directories from the password store (~/.password-store or $PASSWORD_STORE_DIR). Two generators: - entries: lists .gpg files with prefix/extension stripped (for show, edit, rm, mv, cp, and top-level pass-name arg) - entry_dirs: lists directories (for ls subfolder arg) Co-Authored-By: Oz <oz-agent@warp.dev>
Co-Authored-By: Oz <oz-agent@warp.dev>
APP-3516 Add pass (password-store) entry completion
See GitHub #2067 |
Contributor
Author
|
Checked the screenshots uploaded in 86f730c |
peicodes
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Rust-based generators for
pass(password-store) command completions, replacing the existing Fig-style JavaScript generators that Warp does not use.Resolves APP-3516
Changes
New:
command-signatures/src/generators/pass.rsTwo generators:
entries: Lists.gpgfiles from the password store with prefix and extension stripped. Used forshow,edit,rm,mv,cp, and the top-levelpass-nameargument.entry_dirs: Lists directories in the password store. Used for thelssubcommand's subfolder argument.Both generators respect the
PASSWORD_STORE_DIRenvironment variable, falling back to~/.password-store.Modified:
command-signatures/json/pass.jsonReplaced all JavaScript
generatorsblocks withgeneratorNamereferences to the new Rust generators.Modified:
command-signatures/src/generators/mod.rsRegistered the new
passmodule.Generator Verification Screenshots
pass <Tab>— entries generator (top-level)pass ls <Tab>— entry_dirs generatorpass show <Tab>— entries generatorpass edit <Tab>— entries generatorConversation: https://staging.warp.dev/conversation/ba72eca3-df0f-45c6-9d1f-b30a90c44dd8
Run: https://oz.staging.warp.dev/runs/019d4aa6-cd82-7ab9-a394-b9c4d1d46fe4
This PR was generated with Oz.