Skip to content

Add completion spec: pass (password-store)#221

Merged
lucieleblanc merged 3 commits into
mainfrom
app-3516/command-spec-pass
Apr 3, 2026
Merged

Add completion spec: pass (password-store)#221
lucieleblanc merged 3 commits into
mainfrom
app-3516/command-spec-pass

Conversation

@lucieleblanc

Copy link
Copy Markdown
Contributor

Summary

Adds Rust-based generators for pass (password-store) command completions, replacing the existing Fig-style JavaScript generators that Warp does not use.

Resolves APP-3516

Changes

New: command-signatures/src/generators/pass.rs

Two generators:

  • entries: Lists .gpg files from the password store with prefix and extension stripped. Used for show, edit, rm, mv, cp, and the top-level pass-name argument.
  • entry_dirs: Lists directories in the password store. Used for the ls subcommand's subfolder argument.

Both generators respect the PASSWORD_STORE_DIR environment variable, falling back to ~/.password-store.

Modified: command-signatures/json/pass.json

Replaced all JavaScript generators blocks with generatorName references to the new Rust generators.

Modified: command-signatures/src/generators/mod.rs

Registered the new pass module.

Generator Verification Screenshots

pass <Tab> — entries generator (top-level)

pass entries

pass ls <Tab> — entry_dirs generator

pass dirs

pass show <Tab> — entries generator

pass show

pass edit <Tab> — entries generator

pass edit


Conversation: https://staging.warp.dev/conversation/ba72eca3-df0f-45c6-9d1f-b30a90c44dd8
Run: https://oz.staging.warp.dev/runs/019d4aa6-cd82-7ab9-a394-b9c4d1d46fe4

This PR was generated with Oz.

oz-agent added 2 commits April 1, 2026 20:20
Replace Fig-style JavaScript generators in pass.json with Rust-based
generators that list password entries and directories from the password
store (~/.password-store or $PASSWORD_STORE_DIR).

Two generators:
- entries: lists .gpg files with prefix/extension stripped (for show,
  edit, rm, mv, cp, and top-level pass-name arg)
- entry_dirs: lists directories (for ls subfolder arg)

Co-Authored-By: Oz <oz-agent@warp.dev>
Co-Authored-By: Oz <oz-agent@warp.dev>
@linear

linear Bot commented Apr 1, 2026

Copy link
Copy Markdown
APP-3516 Add pass (password-store) entry completion

pass.json spec exists but has no Rust generator. pass <TAB> should list entries from ~/.password-store directory tree.

See GitHub #2067

@lucieleblanc

Copy link
Copy Markdown
Contributor Author

Checked the screenshots uploaded in 86f730c

@lucieleblanc lucieleblanc marked this pull request as ready for review April 1, 2026 21:04
@lucieleblanc lucieleblanc merged commit e43fab8 into main Apr 3, 2026
3 checks passed
@lucieleblanc lucieleblanc deleted the app-3516/command-spec-pass branch April 3, 2026 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants