Skip to content

Add completion spec: git show#230

Merged
lucieleblanc merged 1 commit into
mainfrom
app-3486/command-spec-git-show
Apr 3, 2026
Merged

Add completion spec: git show#230
lucieleblanc merged 1 commit into
mainfrom
app-3486/command-spec-git-show

Conversation

@lucieleblanc
Copy link
Copy Markdown
Contributor

@lucieleblanc lucieleblanc commented Apr 1, 2026

Summary

Adds comprehensive options to the git show completion spec in git.json, complementing the existing branch/tag/commit generators. Previously, git show only had argument generators but no option definitions.

Addresses APP-3486 / GitHub #2919.

Changes

Added the following options to git show:

  • Format: --format, --oneline, --abbrev-commit, --no-abbrev-commit, --encoding
  • Diff output: -p/-u/--patch, -s/--no-patch, -q/--quiet, --stat, --numstat, --shortstat, --raw, --name-only, --name-status
  • Display: --color, --no-color, --diff-filter, --show-signature
  • Notes: --notes, --no-notes
  • Tabs: --expand-tabs, --no-expand-tabs
  • Separator: --

Screenshots

Branch completions (git show <Tab>)

git-show-branches

Option completions (git show --<Tab>)

git-show-options

Testing

  • All presubmit checks pass (prettier, cargo fmt, clippy, tests)
  • Verified end-to-end in a local Warp build: branch completions and option completions both work correctly

Conversation: https://staging.warp.dev/conversation/a3f2c610-1d16-421a-b3b3-b5edbe8cfa50
Run: https://oz.staging.warp.dev/runs/019d4b03-ef64-7a8a-9574-5e7ae3fd9460
This PR was generated with Oz.

@linear
Copy link
Copy Markdown

linear Bot commented Apr 1, 2026

APP-3486 [git] Wire branch completion into git show

Wire branch completion generators into git show argument position in git.json.

See GitHub #2919

lucieleblanc added a commit that referenced this pull request Apr 1, 2026
lucieleblanc added a commit that referenced this pull request Apr 1, 2026
Add comprehensive options to the git show subcommand in git.json,
complementing the existing branch/tag/commit generators. Options include
format, diff output, display, notes, and tab expansion settings.

Closes APP-3486

Co-Authored-By: Oz <oz-agent@warp.dev>
@lucieleblanc lucieleblanc force-pushed the app-3486/command-spec-git-show branch from 738f02a to b10eca6 Compare April 1, 2026 22:16
Copy link
Copy Markdown
Contributor Author

lucieleblanc commented Apr 1, 2026

Screenshots

Branch completions (git show <Tab>)

git-show-branches

Option completions (git show --<Tab>)

git-show-options

@lucieleblanc lucieleblanc force-pushed the app-3486/command-spec-git-show branch from e0c016a to b10eca6 Compare April 1, 2026 22:18
@lucieleblanc
Copy link
Copy Markdown
Contributor Author

Screenshots:
image

image

@lucieleblanc lucieleblanc marked this pull request as ready for review April 3, 2026 16:13
@lucieleblanc lucieleblanc merged commit 878db70 into main Apr 3, 2026
6 checks passed
@lucieleblanc lucieleblanc deleted the app-3486/command-spec-git-show branch April 3, 2026 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants