Fix git status parser to handle paths with spaces and renames (#271)#272
Open
nickeddy wants to merge 1 commit into
Open
Fix git status parser to handle paths with spaces and renames (#271)#272nickeddy wants to merge 1 commit into
nickeddy wants to merge 1 commit into
Conversation
…tdev#271) Switch `files_for_staging` to `git status --short -z` so paths arrive NUL-separated and unquoted, and parse each record by taking everything after the 3-byte `XY ` status prefix instead of splitting on whitespace. This preserves filenames containing spaces, and the parser now skips the source record of rename (`R`) and copy (`C`) entries since only the destination exists on disk. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch
files_for_stagingtogit status --short -zso paths arrive NUL-separated and unquoted, and parse each record by taking everything after the 3-byteXYstatus prefix instead of splitting on whitespace. This preserves filenames containing spaces, and the parser now skips the source record of rename (R) and copy (C) entries since only the destination exists on disk.