Skip to content

non-multi-arch images now fail with clear error #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
acarl005 merged 1 commit into from
Feb 23, 2026
Merged

non-multi-arch images now fail with clear error #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions internal/worker/worker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,6 +381,22 @@ func (w *Worker) pullImage(ctx context.Context, imageName string, authStr string
if _, err = io.Copy(io.Discard, reader); err != nil {
return fmt.Errorf("failed to read image pull output: %w", err)
}

// Verify the pulled image matches the host platform. Docker may pull an image for a different
// architecture then what is specified in image.PullOptions.Platform
// See: https://github.com/moby/moby/pull/42325
inspect, err := w.dockerClient.ImageInspect(ctx, imageName)
if err != nil {
return fmt.Errorf("failed to inspect pulled image %s: %w", imageName, err)
}
imagePlatform := fmt.Sprintf("%s/%s", inspect.Os, inspect.Architecture)
if imagePlatform != w.platform {
return fmt.Errorf(
"image %s is for platform %s, but this worker requires %s",
imageName, imagePlatform, w.platform,
)
}

log.Infof(ctx, "Successfully pulled image: %s", imageName)
return nil
}
Expand Down