Adding sidecar image param to the k8 worker #45
Merged
Conversation
ab0fc15 to
b359b0f
Compare
bnavetta
approved these changes
Apr 7, 2026
| var sidecars []types.SidecarMount | ||
| if assignment.SidecarImage != "" { | ||
| sidecarImage := assignment.SidecarImage | ||
| if w.config.Kubernetes != nil && w.config.Kubernetes.SidecarImage != "" { |
Collaborator
There was a problem hiding this comment.
Not blocking, but should we support this for the Docker backend as well?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Add
sidecar_imageconfig override to Kubernetes backendProblem
Customers running EKS in restricted network zones cannot pull the sidecar image (
docker.io/warpdotdev/warp-agent:latest) directly from Docker Hub. The sidecar image reference is sent by the server in each task assignment and injected as an init container in the Kubernetes Job. There is currently no way to override this to point at an internal mirror (e.g. an ECR pull-through cache).Solution
Add a new
sidecar_imageconfig field to the Kubernetes backend. When set, it replaces the server-provided sidecar image reference for the warp-agent sidecar (mounted at/agent).Precedence: config
sidecar_image> server-provided image (same pattern aspreflight_image).Changes
sidecar_imagefield toKubernetesConfigandKubernetesBackendConfigwithno_whitespacevalidationprepareTaskParamsinworker.gouses the config override when set, with an info log noting the substitutionkubernetesBackend.sidecarImagevalue and conditional configmap emissionprepareTaskParamsoverride tests (override wins, server fallback, no sidecar when server sends empty)Example config
Oz conversation | Plan
Co-Authored-By: Oz oz-agent@warp.dev