Skip to content

Commit 1c3b882

Browse files
authored
Bump claude plugin version (to fix broken notifications) (#11204)
## Description <!-- Please remember to add your design buddy onto the PR for review, if it contains any UI changes! --> There was a bug caused by a claude code release that made it so our plugin could no longer emit OSC 777 events, breaking notifications. Claude code released a fix for this with a new notifications field, which we leverage in this PR: warpdotdev/claude-code-warp#52. We should encourage folks to download the new plugin so that notifications are fixed for them. ## Linked Issue <!-- Link the GitHub issue this PR addresses. Before opening this PR, please confirm: --> - [x] Where appropriate, screenshots or a short video of the implementation are included below (especially for user-visible or UI changes). Fixes #10715. ## Testing <!-- How did you test this change? What automated tests did you add? If you didn't add any new tests, what's your justification for not adding any? Manual testing is required for changes that can be manually tested, and almost all changes can be manually tested. If your change can be manually tested, please include screenshots or a screen recording that show it working end to end. You can run the app locally using `./script/run` - see WARP.md for more details on how to get set up. --> - [x] I have manually tested my changes locally with `./script/run` ### Screenshots / Videos <!-- Attach screenshots or a short video demonstrating the change, where appropriate. Remove this section if it is not relevant to your PR. --> https://www.loom.com/share/d81b295807544269b57eb8d811575b28 ## Agent Mode - [x] Warp Agent Mode - This PR was created via Warp's AI Agent Mode <!-- ## Changelog Entries for Stable The entries below will be used when constructing a soft-copy of the stable release changelog. Leave blank or remove the lines if no entry in the stable changelog is needed. Entries should be on the same line, without the `{{` `}}` brackets. You can use multiple lines, even of the same type. The valid suffixes are: - NEW-FEATURE: for new, relatively sizable features. Features listed here will likely have docs / social media posts / marketing launches associated with them, so use sparingly. - IMPROVEMENT: for new functionality of existing features. - BUG-FIX: for fixes related to known bugs or regressions. - IMAGE: the image specified by the URL (hosted on GCP) will be added to Dev & Preview releases. For Stable releases, see the pinned doc in the #release Slack channel. - OZ: Oz-related updates. Use `CHANGELOG-OZ`. At most 4 Oz updates are shown in-app per release. - NONE: Explicitly opt out of changelog inclusion. Use `CHANGELOG-NONE` for PRs that should never appear in the changelog (e.g. refactors, internal tooling, CI changes). This prevents the changelog agent from inferring an entry. CHANGELOG-NEW-FEATURE: {{text goes here...}} CHANGELOG-IMPROVEMENT: {{text goes here...}} CHANGELOG-BUG-FIX: Fixed rich claude code notifications (with new plugin version) CHANGELOG-BUG-FIX: {{more text goes here...}} CHANGELOG-IMAGE: {{GCP-hosted URL goes here...}} CHANGELOG-OZ: {{text goes here...}} CHANGELOG-NONE -->
1 parent 23c9089 commit 1c3b882

2 files changed

Lines changed: 1 addition & 14 deletions

File tree

app/src/terminal/cli_agent_sessions/plugin_manager/claude.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ const PLATFORM_MARKETPLACE_REPO: &str = "warpdotdev/claude-code-warp-internal";
2525

2626
// Keep in sync with the plugin version in warpdotdev/claude-code-warp.
2727
// (See the Versioning section of that repo's README.)
28-
const MINIMUM_PLUGIN_VERSION: &str = "2.0.0";
28+
const MINIMUM_PLUGIN_VERSION: &str = "2.1.0";
2929

3030
pub(super) struct ClaudeCodePluginManager {
3131
executor: LocalCommandExecutor,

app/src/terminal/cli_agent_sessions/plugin_manager/claude_tests.rs

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -133,19 +133,6 @@ fn not_installed_via_trait_when_claude_home_empty() {
133133
assert!(!result);
134134
}
135135

136-
#[test]
137-
fn can_auto_install_is_true() {
138-
assert!(ClaudeCodePluginManager::new(None, None, None).can_auto_install());
139-
}
140-
141-
#[test]
142-
fn minimum_version() {
143-
assert_eq!(
144-
ClaudeCodePluginManager::new(None, None, None).minimum_plugin_version(),
145-
"2.0.0"
146-
);
147-
}
148-
149136
#[test]
150137
fn installed_version_returns_version_when_present() {
151138
let dir = tempfile::tempdir().unwrap();

0 commit comments

Comments
 (0)