Skip to content

Commit 5ffcb5e

Browse files
cephalonautoz-agent
andcommitted
Fix 4 unused variable warnings
- Remove fetch_in_flight in apply_lifecycle (code now calls apply_started directly) - Simplify Pending arm pane creation to is_none() check (pane_id was unused) - Remove root_task binding in hydrate_owner_child_transcript (never referenced) - Remove has_ambient_model binding in attach_execution_session_to_ambient_pane Co-Authored-By: Oz <oz-agent@warp.dev>
1 parent 9c46577 commit 5ffcb5e

3 files changed

Lines changed: 5 additions & 12 deletions

File tree

app/src/ai/blocklist/orchestration_child_tracker.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -264,7 +264,6 @@ impl OrchestrationChildTracker {
264264
ctx: &mut ModelContext<OrchestrationEventStreamer>,
265265
) {
266266
let tracker_known = self.children.contains_key(&task_id);
267-
let fetch_in_flight = self.metadata_fetches.contains(run_id);
268267
if tracker_known {
269268
let status = conversation_status_from_lifecycle_event_type(kind);
270269
// Write status through immediately so the pill bar badge reflects

app/src/pane_group/child_agent/hydration.rs

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -204,11 +204,12 @@ impl PaneGroup {
204204
// generic cloud-agent composing zero state. Register so that
205205
// process_pending_remote_child_hydrations re-drives when
206206
// evict_and_refetch_task fires TasksUpdated with fresh data.
207-
let Some(pane_id) =
208-
self.create_owner_loading_child_placeholder(child_conversation, ctx)
209-
else {
207+
if self
208+
.create_owner_loading_child_placeholder(child_conversation, ctx)
209+
.is_none()
210+
{
210211
return;
211-
};
212+
}
212213
self.pending_remote_child_hydrations
213214
.insert(task_id, child_id);
214215
self.ensure_pending_ambient_restoration_subscription(ctx);
@@ -514,8 +515,6 @@ impl PaneGroup {
514515
return;
515516
}
516517
};
517-
let root_task = merged.get_root_task();
518-
519518
let blocks_cloud_followups =
520519
task.as_ref().is_none_or(AmbientAgentTask::blocks_cloud_followups);
521520
match completed_child_presentation(access, blocks_cloud_followups) {

app/src/pane_group/mod.rs

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7029,11 +7029,6 @@ impl PaneGroup {
70297029
return false;
70307030
};
70317031

7032-
let has_ambient_model = terminal_view
7033-
.as_ref(ctx)
7034-
.ambient_agent_view_model()
7035-
.is_some();
7036-
70377032
if let Some(ambient_agent_view_model) = terminal_view
70387033
.as_ref(ctx)
70397034
.ambient_agent_view_model()

0 commit comments

Comments
 (0)