Skip to content

Commit c917be0

Browse files
Publish Windows TUI installer artifacts (#14601)
## Description Publish the signed Windows Warp Agent CLI installer through the same release paths used by the GUI and macOS/Linux TUI pipelines. The Windows TUI release job previously stored `WarpAgentCLIDevSetup.exe` only as a GitHub Actions artifact, while the installer and autoupdater redirected to an immutable object under `releases.warp.dev`. This caused Windows installs and updates to fail with `NoSuchKey`. This change: - attaches publishing-run installers to the GitHub release - uploads the installer to `warp-releases/<channel>/<version>/tui/windows/x86_64` - verifies the release URL after upload - gates dev changelog publication on successful Windows TUI artifact publication - preserves the existing workflow artifact containing the installer and PDB Implementation plan: https://staging.warp.dev/drive/notebook/wUXy09hFTN6HDX7irNLgsp ## Linked Issue - [ ] The linked issue is labeled `ready-to-spec` or `ready-to-implement`. - [ ] Where appropriate, screenshots or a short video of the implementation are included below (especially for user-visible or UI changes). ## Testing - `./script/format` - GitHub Actions workflow/YAML validation - `git diff --check` - Recovered the signed installer from release run `30641310846` and uploaded it to the expected immutable GCS path without rerunning the release - Verified the latest and version-pinned staging endpoints redirect to the published installer and return HTTP 200 - Verified the downloaded installer SHA-256 matches the workflow artifact: `ee1ba2a6964525218965155d256f0f8bb695fca060c886071a43438f2023e7a4` - Clippy was not run for this workflow-only change - [ ] I have manually tested my changes locally with `./script/run` ## Agent Mode - [x] Warp Agent Mode - This PR was created via Warp's AI Agent Mode CHANGELOG-NONE Co-Authored-By: Warp <agent@warp.dev> Co-authored-by: Warp <agent@warp.dev>
1 parent c1986e5 commit c917be0

1 file changed

Lines changed: 34 additions & 3 deletions

File tree

.github/workflows/create_release.yml

Lines changed: 34 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1698,6 +1698,34 @@ jobs:
16981698
AZURE_CLIENT_ID: ${{ secrets.AZURE_CLIENT_ID }}
16991699
AZURE_CLIENT_SECRET: ${{ secrets.AZURE_CLIENT_SECRET }}
17001700
SIGN_TOOL_CMD: ${{ steps.setup_signing.outputs.sign_tool_cmd }}
1701+
- name: Add TUI installer to GitHub release assets
1702+
if: ${{ needs.prepare_release.outputs.should_publish == 'true' }}
1703+
uses: softprops/action-gh-release@718ea10b132b3b2eba29c1007bb80653f286566b # v3.0.1
1704+
with:
1705+
tag_name: ${{ needs.prepare_release.outputs.release_tag }}
1706+
files: ${{ steps.bundle_tui.outputs.installer_path }}
1707+
token: ${{ secrets.GITHUB_TOKEN }}
1708+
1709+
- uses: google-github-actions/auth@7c6bc770dae815cd3e89ee6cdf493a5fab2cc093 # v3.0.0
1710+
if: ${{ needs.prepare_release.outputs.should_publish == 'true' }}
1711+
with:
1712+
credentials_json: ${{ secrets.GOOGLE_APPLICATION_CREDENTIALS }}
1713+
1714+
- name: Upload TUI installer to Google Cloud Storage
1715+
if: ${{ needs.prepare_release.outputs.should_publish == 'true' }}
1716+
uses: google-github-actions/upload-cloud-storage@e95a15f226403ed658d3e65f40205649f342ba2c # v1
1717+
with:
1718+
path: ${{ steps.bundle_tui.outputs.installer_path }}
1719+
destination: warp-releases/${{ steps.get-config.outputs.channel }}/${{ needs.prepare_release.outputs.release_tag }}/tui/windows/x86_64
1720+
headers: |-
1721+
cache-control: ${{ steps.get-config.outputs.gcs_cache_control_value }}
1722+
1723+
- name: Verify TUI installer in Google Cloud Storage
1724+
if: ${{ needs.prepare_release.outputs.should_publish == 'true' }}
1725+
run: |
1726+
curl.exe --fail --silent --show-error --head \
1727+
"https://releases.warp.dev/${{ steps.get-config.outputs.channel }}/${{ needs.prepare_release.outputs.release_tag }}/tui/windows/x86_64/WarpAgentCLIDevSetup.exe"
1728+
shell: bash
17011729

17021730
- name: Upload Windows TUI installer
17031731
uses: actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f # v6
@@ -1937,6 +1965,7 @@ jobs:
19371965
- prepare_release
19381966
- release_macos_tui
19391967
- release_linux_tui
1968+
- release_windows_tui
19401969
if: ${{ always() }}
19411970
steps:
19421971
- name: Verify TUI release artifacts
@@ -1946,13 +1975,15 @@ jobs:
19461975
CHANNEL: ${{ inputs.channel }}
19471976
MACOS_TUI_RESULT: ${{ needs.release_macos_tui.result }}
19481977
LINUX_TUI_RESULT: ${{ needs.release_linux_tui.result }}
1978+
WINDOWS_TUI_RESULT: ${{ needs.release_windows_tui.result }}
19491979
run: |
19501980
if [[ "$SHOULD_PUBLISH" != "true" || ( "$CHANNEL" != "dev" && "$CHANNEL" != "preview" ) ]]; then
19511981
exit 0
19521982
fi
1953-
1954-
if [[ "$MACOS_TUI_RESULT" != "success" || "$LINUX_TUI_RESULT" != "success" ]]; then
1955-
echo "::error::TUI release artifacts were not published successfully (macOS: $MACOS_TUI_RESULT, Linux: $LINUX_TUI_RESULT)"
1983+
if [[ "$MACOS_TUI_RESULT" != "success" ||
1984+
"$LINUX_TUI_RESULT" != "success" ||
1985+
( "$CHANNEL" == "dev" && "$WINDOWS_TUI_RESULT" != "success" ) ]]; then
1986+
echo "::error::TUI release artifacts were not published successfully (macOS: $MACOS_TUI_RESULT, Linux: $LINUX_TUI_RESULT, Windows: $WINDOWS_TUI_RESULT)"
19561987
exit 1
19571988
fi
19581989

0 commit comments

Comments
 (0)