Commit d84b4e3
[fix](VA) Keep non-zero wait action groups in computer-use recordings (#14540)
## Description
Computer-use recordings on Linux are smart-trimmed: only committed
action groups produce keep-windows, and everything else is hard-cut.
`is_meaningful_action_group` treated every `Wait`-only batch as
non-meaningful, so a standalone "wait for the UI to settle" call was
never committed and its settling period was cut from the video, even
though it plays out in real time on screen.
This changes the predicate to count any non-zero `Wait` as meaningful
(via the existing `Action::is_no_op()` helper), while `Wait(0)` no-op
batches — emitted for screenshot/zoom/cursor-position-only calls —
remain excluded so empty frames are still trimmed. Non-`Wait` actions
are unaffected. The commit path already records the full wait duration
in the group's `[offset, finish_offset]` span, so no other changes are
needed.
## Linked Issue
N/A — recording-quality fix from the CU video trim pipeline work.
- [ ] The linked issue is labeled `ready-to-spec` or
`ready-to-implement`.
- [ ] Where appropriate, screenshots or a short video of the
implementation are included below (especially for user-visible or UI
changes).
## Testing
Updated the existing `is_meaningful_action_group` unit test: a 500 ms
wait-only group now asserts meaningful, while the `Wait(0)` and
empty-slice cases keep asserting non-meaningful.
Ran locally (macOS):
- `cargo nextest run -p computer_use` — 62 passed, 0 skipped
- `./script/format --check` — clean
- `cargo clippy --workspace --exclude warp_completer --all-targets
--tests -- -D warnings` — clean
- `cargo clippy -p warp --all-targets --tests -- -D warnings` — clean
- `cargo clippy -p warp_completer --all-targets --tests -- -D warnings`
— clean
Not manually tested with `./script/run`: the trim only runs on Linux
recordings, and the change is fully covered by the unit test on the pure
predicate.
- [ ] I have manually tested my changes locally with `./script/run`
## Agent Mode
- [x] Warp Agent Mode - This PR was created via Warp's AI Agent Mode
Conversation:
https://staging.warp.dev/conversation/df74c6da-5f2a-4a0f-99a6-7b9e8b64cb1f
Run:
https://oz.staging.warp.dev/runs/019fb41e-c9c2-778f-844e-afcf68f7bf0e
CHANGELOG-BUG-FIX: Computer-use video recordings now keep real
(non-zero) wait periods at real time instead of trimming them out.
Co-Authored-By: Oz <oz-agent@warp.dev>
Co-authored-by: Oz <oz-agent@warp.dev>1 parent b462e01 commit d84b4e3
2 files changed
Lines changed: 9 additions & 10 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
52 | 52 | | |
53 | 53 | | |
54 | 54 | | |
55 | | - | |
56 | | - | |
57 | | - | |
58 | | - | |
59 | | - | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
60 | 61 | | |
61 | | - | |
62 | | - | |
63 | | - | |
| 62 | + | |
64 | 63 | | |
65 | 64 | | |
66 | 65 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
136 | 136 | | |
137 | 137 | | |
138 | 138 | | |
139 | | - | |
| 139 | + | |
140 | 140 | | |
141 | 141 | | |
142 | 142 | | |
143 | 143 | | |
144 | | - | |
| 144 | + | |
145 | 145 | | |
146 | 146 | | |
147 | 147 | | |
| |||
0 commit comments