Fix Third party CLI agents Settings search results and keep the page title visible (#14524)

## Description

Settings → Agents → **Third party CLI agents** was a single monolithic
`CLIAgentWidget`, so a search that matched one control returned the
entire page. Fixing that surfaced two follow-on issues with how settings
pages render their title, both addressed here.

- Split the page into seven focused `SettingsWidget`s so settings search
filters at row/section granularity.
- Preserve the existing empty-search layout, feature/setting gating, and
the `cli_agents` deeplink target.
- **Keep the page title visible while the rows are filtered**, on both
Third party CLI agents and Editor and Code Review. The heading used to
be drawn inside a widget, so any search term that filtered that widget
out also removed the page title. Headings are now passed to `PageType`
as page-level chrome, which the renderer draws once outside the filtered
widget loop — the same affordance the Knowledge sub-page adopted in
#14519 and the Account page has always used. `CodeSubpageHeaderWidget`,
a header-only entry in the searchable widget list, is deleted outright.
- **Make the title-to-content gap consistent across titled pages.**
`PAGE_TITLE_MARGIN_BOTTOM` now reuses the existing `HEADER_PADDING`
token, and the five pages that carried their own additional leading
spacing no longer do, so every titled page derives that gap from the
shared page chrome alone.

### Per-page spacing sources removed

Each of these was an independent source that stacked on top of the
shared title gap:

- **Account** — `AccountWidget` wrapped its content in a 24px top margin
(`VERTICAL_MARGIN`).
- **Billing and Usage** — `BillingAndUsageWidget` wrapped its child view
in a 15px top margin (`HEADER_PADDING`).
- **Referrals** — the invite section wrapped its first label in 28px top
padding (`PAGE_PADDING`).
- **Shared blocks** — the header was wrapped in an extra hardcoded 24px
bottom margin on top of `render_page_title`'s own gap.
- **Privacy** — `SecretRedactionWidget` wrapped its column in 28px top
padding (`PAGE_PADDING`).

Scope note: `Warp Agent` and `Agent profiles` deliberately keep no
page-level title. They are multi-section pages whose per-widget headings
(`Active AI`, `Input`, `Voice`, `API Keys`, …) name individual sections,
so those headings correctly disappear along with their own rows when
filtered. Only single-topic pages, whose one heading names the whole
page, belong in page chrome.

## Linked Issue


[APP-5058](https://linear.app/warpdotdev/issue/APP-5058/third-party-cli-agents-settings-sub-page-doesnt-use-widgets-correctly)

Originating thread:
https://warpdev.slack.com/archives/C0BDQDW8V5E/p1785374792001539

## Testing

- [x] `./script/format`
- [x] `CARGO_INCREMENTAL=0 cargo clippy -p warp --bin warp -- -D
warnings`
- [x] `CARGO_INCREMENTAL=0 cargo clippy -p warp --bin warp --tests -- -D
warnings`
- [x] `CARGO_INCREMENTAL=0 cargo build --bin warp`
- [x] Earlier PR CI green on the pre-merge head: 20 passed, 9 skipped, 0
failing
- [x] Computer-use verification of title persistence on **Third party
CLI agents**: with `toolbar layout`, `coding agent toolbar` and `ctrl
enter` active, the bold heading stays at the top; clearing restores the
page with the heading intact.
- [x] Computer-use verification of title persistence on **Editor and
Code Review**: baseline 13 rows with the heading; `auto save` filters to
1 row (`Auto save`) with the heading still shown; `project explorer`
filters to 2 rows (`Project explorer`, `Show hidden files in project
explorer`) with the heading still shown; clearing restores all 13 rows
with the heading present.
- [x] Computer-use verification of spacing across eight titled pages.
Six now render an identical gap of roughly half the heading's text
height: Billing and Usage, Referrals, Privacy, Knowledge, Third party
CLI agents, and Editor and Code Review. No overlapping text, duplicated
headings, missing headings, or clipped content on any page.

The two APP-5058 regression tests added earlier were removed at the
requester's explicit request; computer-use proof is the behavior-level
verification for this change.

### Two pages still show a larger gap, for a reason that is not title
padding

Verification was done in a logged-out session, and on two pages the
remaining space is page content rather than the title gap. Both had
their genuine duplicate padding source removed above.

- **Account** — below the heading sits `AccountWidget`'s account-info
block (avatar, name, email, plan badge), which renders empty when logged
out, followed by the deliberate `DividerWidget` separator that carries
its own 24px top margin. That divider separates the account block from
the settings below and is doing real work, so it was left alone rather
than absorbed into the title gap. In a logged-in session the band should
be filled by the account block. **Worth a glance on a logged-in build.**
- **Shared blocks** — the page was in its `Failed to load blocks. Please
try again.` state, which is a centered message rendered through a helper
that applies uniform `PAGE_PADDING`. That padding belongs to the
empty/error state, not the title.

### Capture access note

Artifact download links require Warp authentication. The GitHub App
installation token available to this run cannot use GitHub's
user-attachment uploader, so each state is also described in words above
and the captures are preserved on the linked Oz run.

<!-- oz:computer-use-screenshots start -->
### Computer-use screenshots

![Search 'ctrl enter' narrows the sidebar to only 'Third party CLI
agents (1)', while the main content area remains the same 7
rows.](https://staging.warp.dev/api/v1/agent/artifacts/019fb5ca-2c7d-79ee-8144-ea3cf48d7fa2/download)
![After clearing the search, the sidebar is fully restored and the main
content area shows the same 7 rows as
baseline.](https://staging.warp.dev/api/v1/agent/artifacts/019fb5ca-7c4b-704a-95ae-26b44a1ec47f/download)
![Third party CLI agents settings page with search "ctrl enter" active —
the sidebar is filtered to one entry but the main content area still
shows all 7 setting
rows.](https://staging.warp.dev/api/v1/agent/artifacts/019fb5d4-1141-7989-aec7-6986b4965d48/download)
![Third party CLI agents settings page with an empty sidebar search box,
showing all setting
rows.](https://staging.warp.dev/api/v1/agent/artifacts/019fb5d7-523c-7e65-bb61-afa0fcc4b674/download)
![With "toolbar layout" typed in the sidebar search, the sidebar filters
(Third party CLI agents (1)) but the main content area still shows all 7
rows and the
heading.](https://staging.warp.dev/api/v1/agent/artifacts/019fb5d8-1d7f-7704-b63b-bedf81c9e94c/download)
![Third party CLI agents settings page showing the heading and first row
with a clear whitespace band between
them.](https://staging.warp.dev/api/v1/agent/artifacts/019fb5e3-34d5-7aa5-9875-33f8d5843a1e/download)
![Knowledge settings page showing heading and first row 'Rules' with a
whitespace band between
them.](https://staging.warp.dev/api/v1/agent/artifacts/019fb5e3-a01c-782d-b1bf-2ea63f12c27f/download)
![Privacy settings page showing heading and 'Secret redaction' with a
larger whitespace band between
them.](https://staging.warp.dev/api/v1/agent/artifacts/019fb5e4-2bc1-7e98-800b-e1b08392dc12/download)
![Editor and Code Review settings page filtered by the search term "auto
save", showing the heading and only the Auto save
row.](https://staging.warp.dev/api/v1/agent/artifacts/019fb689-4b17-75c6-a4e7-fc19b6917165/download)
![Editor and Code Review page restored to its full 13-row list after
clearing the search box, heading
present.](https://staging.warp.dev/api/v1/agent/artifacts/019fb68a-22fa-7d03-ab77-c2d2936ac6ee/download)
<!-- oz:computer-use-screenshots end -->

<!-- oz:computer-use-videos start -->
### Computer-use video recordings

[View video recording: Investigating whether the Third party CLI agents
settings list narrows to matching rows when searching, and what action
(typing, page switch, resize, scroll) triggers the
repaint.](https://staging.warp.dev/api/v1/agent/artifacts/019fb5d4-385f-7b49-b261-352ca5896a13/download)
<!-- oz:computer-use-videos end -->

### Follow-up candidates found while sweeping (deliberately NOT changed
here)

Two more pages have the same signature — a single-topic page whose one
heading lives inside a searchable widget, so an active search term can
filter the title away:

- **Warpify** (`warpify_page.rs`) — categorized page with a `None`
title; the "Warpify" heading lives in `TitleWidget` inside an unnamed
category.
- **Warp Drive** (`warp_drive_page.rs`) — uncategorized page with a
`None` title and a header-only `WarpDriveHeaderWidget`, structurally
identical to the `CodeSubpageHeaderWidget` deleted here.

Monolith pages (Shared blocks, Keybindings, Teams, Oz cloud API keys,
About, Environments) are **not** affected: their filter is
all-or-nothing, so the title never vanishes while rows remain.
Multi-section pages (Appearance, Features, Warp Agent, Agent profiles)
are also not affected, because their headings legitimately belong to
individual sections.

### Rework changes

- **Page title disappeared under an active search term (requester
report).** Moved the `Third party CLI agents` heading out of
`CLIAgentWidget::render` into `PageType`'s page-title slot, mirroring
the Knowledge sub-page (#14519) rather than inventing a new mechanism.
- **Padding below the page title (requester follow-up).** Pointed
`PAGE_TITLE_MARGIN_BOTTOM` at the existing `HEADER_PADDING` token so
promoting a heading to chrome no longer tightens the gap. This also
fixed the same regression Knowledge inherited from #14519.
- **Too much padding on five pages (requester follow-up).** Diagnosed
each page separately; all five genuinely had their own leading-spacing
source stacking on the shared gap, and each was removed in favour of the
shared page-title padding. Details in the "Per-page spacing sources
removed" section above.
- **`Editor and Code Review` title disappearing under search (requester
follow-up).** Deleted the header-only `CodeSubpageHeaderWidget` and
passed `subpage.title()` through `PageType` instead. This covers both
Code subpages, since they shared that widget. No deeplink targets
reference it. The legacy all-widgets Code view keeps its categorized
section headers, matching the precedent set for Third party CLI agents.
- **Removed the `PAGE_TITLE_MARGIN_BOTTOM` doc comment** at the
requester's request; the surrounding constants carry none, and its
rationale went stale once the per-page sources were consolidated.
- **Brought current with `master`.** Merged rather than rebased, since
the branch is shared and already carried merge commits. Conflict-free,
including in `ai_page.rs`.
- **Behaviour note:** deleting `CodeSubpageHeaderWidget` also removes
the only widget whose `search_terms` were the literal page title, so
searching the exact string `editor and code review` no longer matches
this page. Previously it matched and rendered a bare heading with no
controls, which was not useful; searching any real term (`editor`, `auto
save`, `project explorer`) still works and now keeps the title visible.

## Agent Mode

- [x] Warp Agent Mode - This PR was created via Warp's AI Agent Mode

CHANGELOG-BUG-FIX: Fixed Settings search returning the entire Third
party CLI agents page for a single matching control, kept page titles
visible while results are filtered, and made the spacing below settings
page titles consistent.

<!-- factory-agent:
{"source":"factory-agent","task_id":"APP-5058","task_source":"linear","task_url":"https://linear.app/warpdotdev/issue/APP-5058/third-party-cli-agents-settings-sub-page-doesnt-use-widgets-correctly","linear_issue_id":"APP-5058","oz_run_id":"019fb57a-8c8e-7165-8f6e-17b12361320b","repo":"warpdotdev/warp","pr_url":"https://github.com/warpdotdev/warp/pull/14524","review_rework_attempts":1}
-->

_Conversation:
https://staging.warp.dev/conversation/4cf9720f-91f5-466c-a005-23a629a7e655_
_Run:
https://oz.staging.warp.dev/runs/019fb57a-8c8e-7165-8f6e-17b12361320b_

Co-Authored-By: Warp <agent@warp.dev>
Co-Authored-By: Oz <oz-agent@warp.dev>

---------

Co-authored-by: Andy <andy@warp.dev>

Author: warp-agent-staging[bot]

app/src/settings_view/ai_page.rs

@@ -3,14 +3,14 @@
 
 use warp_core::features::FeatureFlag;
 use warp_core::ui::appearance::Appearance;
-use warpui::elements::{ChildView, Container};
+use warpui::elements::ChildView;
 use warpui::{AppContext, Element, Entity, SingletonEntity, View, ViewContext, ViewHandle};
 
 use super::SettingsSection;
 use super::billing_and_usage_page::{BillingAndUsagePageEvent, BillingAndUsagePageView};
 use super::billing_and_usage_page_v2::BillingAndUsagePageV2View;
 use super::settings_page::{
-    HEADER_PADDING, MatchData, PageType, SettingsPageMeta, SettingsPageViewHandle, SettingsWidget,
+    MatchData, PageType, SettingsPageMeta, SettingsPageViewHandle, SettingsWidget,
 };
 use crate::auth::{AuthManager, AuthStateProvider};
 use crate::workspaces::user_workspaces::UserWorkspaces;
@@ -155,13 +155,10 @@ impl SettingsWidget for BillingAndUsageWidget {
         _appearance: &Appearance,
         app: &AppContext,
     ) -> Box<dyn Element> {
-        let inner = if view.use_v2(app) {
+        if view.use_v2(app) {
             ChildView::new(&view.v2).finish()
         } else {
             ChildView::new(&view.v1).finish()
-        };
-        Container::new(inner)
-            .with_margin_top(HEADER_PADDING)
-            .finish()
+        }
     }
 }

app/src/settings_view/billing_and_usage_dispatch.rs

@@ -40,9 +40,8 @@ use warpui::{
 #[cfg(feature = "local_fs")]
 use super::features::external_editor::ExternalEditorView;
 use super::settings_page::{
-    Category, HEADER_PADDING, MatchData, PageType, SettingsPageMeta, SettingsPageViewHandle,
-    SettingsWidget, TOGGLE_BUTTON_RIGHT_PADDING, build_sub_header, render_body_item,
-    render_separator,
+    Category, MatchData, PageType, SettingsPageMeta, SettingsPageViewHandle, SettingsWidget,
+    TOGGLE_BUTTON_RIGHT_PADDING, render_body_item, render_separator,
 };
 use super::{
     LocalOnlyIconState, SettingsAction, SettingsSection, ToggleSettingActionPair, ToggleState,
@@ -433,10 +432,7 @@ impl CodeSettingsPageView {
                             ctx.dispatch_typed_action(CodeSettingsPageAction::ManualAddDirectory);
                         })
                 });
-                let mut widgets: Vec<Box<dyn SettingsWidget<View = Self>>> =
-                    vec![Box::new(CodeSubpageHeaderWidget {
-                        title: subpage.title(),
-                    })];
+                let mut widgets: Vec<Box<dyn SettingsWidget<View = Self>>> = Vec::new();
                 match subpage {
                     CodeSubpage::Indexing => {
                         widgets.push(Box::new(CodebaseIndexingCategorizedWidget {
@@ -463,9 +459,7 @@ impl CodeSettingsPageView {
                         ]);
                     }
                 }
-                // Subpage widgets render their own subheader-sized titles,
-                // so we don't pass a page-level title.
-                self.page = PageType::new_uncategorized(widgets, None);
+                self.page = PageType::new_uncategorized(widgets, Some(subpage.title()));
             } else {
                 // None: rebuild the full categorized page (all widgets).
                 self.page = Self::build_full_page(ctx);
@@ -2466,30 +2460,6 @@ impl CodePageWidget {
     }
 }
 
-/// A simple widget that renders a subheader title for a Code subpage.
-struct CodeSubpageHeaderWidget {
-    title: &'static str,
-}
-
-impl SettingsWidget for CodeSubpageHeaderWidget {
-    type View = CodeSettingsPageView;
-
-    fn search_terms(&self) -> &str {
-        self.title
-    }
-
-    fn render(
-        &self,
-        _view: &Self::View,
-        appearance: &Appearance,
-        _app: &AppContext,
-    ) -> Box<dyn Element> {
-        build_sub_header(appearance, self.title, None)
-            .with_padding_bottom(HEADER_PADDING)
-            .finish()
-    }
-}
-
 struct CodebaseIndexingCategorizedWidget {
     inner: CodePageWidget,
 }

app/src/settings_view/code_page.rs

@@ -659,11 +659,7 @@ impl SettingsWidget for AccountWidget {
         };
 
         Flex::column()
-            .with_child(
-                Container::new(account_info)
-                    .with_margin_top(VERTICAL_MARGIN)
-                    .finish(),
-            )
+            .with_child(Container::new(account_info).finish())
             .finish()
     }
 }

app/src/settings_view/main_page.rs

@@ -32,7 +32,7 @@ use warpui::{
 
 use super::privacy::{AddRegexModal, AddRegexModalEvent};
 use super::settings_page::{
-    HEADER_PADDING, LocalOnlyIconState, MatchData, PAGE_PADDING, PageType, SettingsPageMeta,
+    HEADER_PADDING, LocalOnlyIconState, MatchData, PageType, SettingsPageMeta,
     SettingsPageViewHandle, SettingsWidget, TOGGLE_BUTTON_RIGHT_PADDING, ToggleState,
     render_body_item, render_sub_header,
 };
@@ -1366,9 +1366,7 @@ impl SettingsWidget for SecretRedactionWidget {
             column.add_child(self.horizontal_divider(appearance));
         }
 
-        Container::new(column.finish())
-            .with_padding_top(PAGE_PADDING)
-            .finish()
+        Container::new(column.finish()).finish()
     }
 }
 

app/src/settings_view/privacy_page.rs

@@ -619,11 +619,7 @@ impl ReferralsWidget {
         appearance: &Appearance,
     ) -> Box<dyn Element> {
         Flex::column()
-            .with_child(
-                Container::new(self.render_label("Link", appearance))
-                    .with_padding_top(PAGE_PADDING)
-                    .finish(),
-            )
+            .with_child(self.render_label("Link", appearance))
             .with_child(self.render_link_row(view, appearance))
             .with_child(self.render_label("Email", appearance))
             .with_child(self.render_email_row(view, appearance))

app/src/settings_view/referrals_page.rs

@@ -57,7 +57,7 @@ pub const TOGGLE_BUTTON_RIGHT_PADDING: f32 = 5.;
 pub const HEADER_PADDING: f32 = 15.;
 pub const CONTENT_FONT_SIZE: f32 = 12.;
 pub const SUBHEADER_MARGIN_BOTTOM: f32 = 4.;
-pub const PAGE_TITLE_MARGIN_BOTTOM: f32 = 4.;
+pub const PAGE_TITLE_MARGIN_BOTTOM: f32 = HEADER_PADDING;
 pub(super) const PAGE_PADDING: f32 = 28.;
 pub(super) const HEADER_FONT_SIZE: f32 = 23.;
 pub const SUBHEADER_FONT_SIZE: f32 = 16.;

app/src/settings_view/settings_page.rs

@@ -799,7 +799,7 @@ impl SettingsWidget for ShowBlocksWidget {
 
         let header = render_page_title("Shared blocks", HEADER_FONT_SIZE, appearance);
         let col = Flex::column()
-            .with_child(Container::new(header).with_margin_bottom(24.).finish())
+            .with_child(header)
             .with_child(Expanded::new(1., stack.finish()).finish());
 
         col.finish()