Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions crates/warpui/src/rendering/wgpu/resources.rs
Original file line number Diff line number Diff line change
Expand Up @@ -535,6 +535,20 @@ pub fn adapter_has_rendering_offset_bug(adapter_info: &wgpu::AdapterInfo) -> boo
.any(|model| adapter_info.name.contains(model))
}

/// Returns whether the adapter is the Broadcom V3D Vulkan driver (V3DV).
///
/// The V3D Vulkan driver on Raspberry Pi and similar ARM SBCs have panics and flickering issues.
/// The logs have warnings about these drivers missing the `FULL_DRAW_INDEX_UINT32` downlevel flag
/// but if it's unclear if that is the actual cause. See:
/// https://github.com/warpdotdev/warp/issues/10618
/// https://github.com/warpdotdev/warp/issues/4879
fn is_v3d_vulkan_adapter(adapter_info: &wgpu::AdapterInfo) -> bool {
cfg!(target_os = "linux")
&& adapter_info.backend == wgpu::Backend::Vulkan
&& adapter_info.driver.contains("V3DV")
&& adapter_info.name.starts_with("V3D 4.2.14.")

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a 4-part version number and we're specifically targeting versions 4.2.14.* as that is the version that appeared in the logs in our user reports. We don't know exactly which versions are affected so this is a start.

Comment thread
acarl005 marked this conversation as resolved.
}

/// Checks whether the provided adapter info describes a lavapipe
/// (Vulkan llvmpipe) adapter that may not work properly with warpui.
fn is_older_lavapipe_adapter(adapter_info: &wgpu::AdapterInfo) -> bool {
Expand Down Expand Up @@ -715,6 +729,11 @@ fn adapter_stability_sort_func(
return AdapterSupport::Unsupported;
}

if is_v3d_vulkan_adapter(&adapter_info) {
log::warn!("Deprioritizing Vulkan-backed V3D adapter");
return AdapterSupport::Unsupported;
}

if is_intel_uhd_620_adapter_on_windows_with_vulkan_backend(&adapter_info) {
log::warn!("Deprioritizing Vulkan-backed Intel UHD 620 adapter");
return AdapterSupport::SupportedWithIssues;
Expand Down
Loading