Show cloud agent env name and setup status for vertical tabs pwd#11006
Conversation
Add setup_status_text() to AgentProgress to deduplicate status text logic. Add cloud_agent_working_directory() helper in vertical_tabs.rs that resolves environment name and setup progress for the working directory subtitle. Wire it into render_terminal_row_content, render_compact_pane_row, and build_vertical_tabs_summary_data so cloud agent tabs show meaningful metadata during startup instead of going blank. Co-Authored-By: Oz <oz-agent@warp.dev>
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
harryalbert
force-pushed
the
harry/app-4367-show-reasonable-subtitle-metadata-for-newnot-yet-started
branch
from
c38b7a5 to
e01ab50
Compare
harryalbert
changed the title
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR deduplicates cloud agent setup status copy and uses cloud environment metadata to populate vertical tab subtitles for ambient agent sessions. The PR includes Loom visual evidence for the user-facing change.
Concerns
- The new vertical tab subtitle helper treats any saved
AgentProgressas an active setup state, butagent_progress()is also present after failed, GitHub-auth-required, and cancelled states. That can leave tabs showing setup progress instead of the terminal's current directory or failure/cancel context after setup has stopped. - Security pass: no security findings.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
| app: &AppContext, | ||
| ) -> Option<String> { | ||
| if !terminal_view.is_ambient_agent_session(app) { | ||
| return None; |
There was a problem hiding this comment.
agent_progress() also returns progress for failed, auth-required, and cancelled states, so those tabs will keep showing setup text; only derive setup text while the model is actually waiting for the session.
harryalbert
requested review from
advait-m and
liliwilson
and removed request for
liliwilson
harryalbert
deleted the
harry/app-4367-show-reasonable-subtitle-metadata-for-newnot-yet-started
branch
2 participants
Summary
There was a weird UI pattern where, after kicking off a cloud run, the directory and branch (which falls back to the directory when there's no branch info) in the vertical tabs would be empty. This looked especially bad if the directory was your vertical tabs title, as then the title would just be empty.
The fix is to show:
Demo
https://www.loom.com/share/1104c17370df4e0f9e1f8e7adfe20b93
Conversation: https://staging.warp.dev/conversation/f142b97d-c442-4ec1-ac77-653ace48f2e2
This PR was generated with Oz.