[QUALITY-729] Promote orchestration client flags to stable#11040
Conversation
Co-Authored-By: Oz <oz-agent@warp.dev>
Co-Authored-By: Oz <oz-agent@warp.dev>
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR promotes orchestration client feature flags to stable defaults and adds compile-time feature bridges for the shared-session viewer pill bar and run_agents tool UI.
Concerns
- The change enables user-facing orchestration UI in stable, but the PR does not include screenshots or a screen recording demonstrating the behavior end to end.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
| "orchestration_v2", | ||
| "orchestration_pill_bar", | ||
| "orchestration_viewer_pill_bar", | ||
| "run_agents_tool", |
There was a problem hiding this comment.
cephalonaut
changed the title
oh we should add a changelog line into this PR description for Stable @cephalonaut though I'm guessing we'll manually edit channel-versions later too |
|
Done |
…v#11040) ## Description Promotes orchestration client flags to stable defaults: orchestration v2, orchestration pill bar, shared-session viewer pill bar, and the run_agents tool call UI. Adds missing Cargo feature declarations and runtime bridges for viewer pill bar and run_agents so stable builds enable the corresponding FeatureFlags. Removes these flags from Preview/Dogfood runtime lists now that they are enabled by default. ## Testing - [x] `cargo fmt --check --manifest-path /Users/matthew/src/prod-flag-flips/warp/Cargo.toml --package warp` - [x] `cargo check --manifest-path /Users/matthew/src/prod-flag-flips/warp/Cargo.toml -p warp_features` - [x] `git --no-pager -C /Users/matthew/src/prod-flag-flips/warp diff --check origin/master...HEAD` Not manually tested with `./script/run`; this is a feature-flag promotion/configuration change. ## Agent Mode - [x] Warp Agent Mode - This PR was created via Warp's AI Agent Mode Agent Mode conversation: https://staging.warp.dev/conversation/b829bb7c-66d9-4f95-ada5-8d3efe85b94a Co-Authored-By: Oz <oz-agent@warp.dev> ## Changelog Entries for Stable CHANGELOG-OZ: Agent orchestration enabled for Stable. Co-authored-by: Oz <oz-agent@warp.dev>
…v#11040) ## Description Promotes orchestration client flags to stable defaults: orchestration v2, orchestration pill bar, shared-session viewer pill bar, and the run_agents tool call UI. Adds missing Cargo feature declarations and runtime bridges for viewer pill bar and run_agents so stable builds enable the corresponding FeatureFlags. Removes these flags from Preview/Dogfood runtime lists now that they are enabled by default. ## Testing - [x] `cargo fmt --check --manifest-path /Users/matthew/src/prod-flag-flips/warp/Cargo.toml --package warp` - [x] `cargo check --manifest-path /Users/matthew/src/prod-flag-flips/warp/Cargo.toml -p warp_features` - [x] `git --no-pager -C /Users/matthew/src/prod-flag-flips/warp diff --check origin/master...HEAD` Not manually tested with `./script/run`; this is a feature-flag promotion/configuration change. ## Agent Mode - [x] Warp Agent Mode - This PR was created via Warp's AI Agent Mode Agent Mode conversation: https://staging.warp.dev/conversation/b829bb7c-66d9-4f95-ada5-8d3efe85b94a Co-Authored-By: Oz <oz-agent@warp.dev> ## Changelog Entries for Stable CHANGELOG-OZ: Agent orchestration enabled for Stable. Co-authored-by: Oz <oz-agent@warp.dev>
2 participants
Description
Promotes orchestration client flags to stable defaults: orchestration v2, orchestration pill bar, shared-session viewer pill bar, and the run_agents tool call UI. Adds missing Cargo feature declarations and runtime bridges for viewer pill bar and run_agents so stable builds enable the corresponding FeatureFlags. Removes these flags from Preview/Dogfood runtime lists now that they are enabled by default.
Testing
cargo fmt --check --manifest-path /Users/matthew/src/prod-flag-flips/warp/Cargo.toml --package warpcargo check --manifest-path /Users/matthew/src/prod-flag-flips/warp/Cargo.toml -p warp_featuresgit --no-pager -C /Users/matthew/src/prod-flag-flips/warp diff --check origin/master...HEADNot manually tested with
./script/run; this is a feature-flag promotion/configuration change.Agent Mode
Agent Mode conversation: https://staging.warp.dev/conversation/b829bb7c-66d9-4f95-ada5-8d3efe85b94a
Co-Authored-By: Oz oz-agent@warp.dev
Changelog Entries for Stable
CHANGELOG-OZ: Agent orchestration enabled for Stable.