QUALITY-715: don't auto-open details panel for parent-orchestrated child agents#11055
Merged
Merged
Conversation
Contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
…ild agents Adds a per-TerminalView ConversationDetailsPanelAutoOpenPolicy so that child agent panes opened from a parent's orchestration UI start with the conversation details side panel closed, while direct shared-session links and ordinary ambient shared-session viewers keep the default auto-open behavior. Suppression is applied in the parent-owned child pane creation paths: - PaneGroup::ensure_shared_session_viewer_child_pane - PaneGroup::create_hidden_child_agent_pane (restored remote children) - PaneGroup::insert_ambient_agent_pane_hidden_for_child_agent (fresh remote children spawned via launch_remote_child, covering the environment-setup → session-ready transition). maybe_auto_open_conversation_details_panel still flips the one-shot has_auto_opened guard, but consults the policy before opening or fetching details. Co-Authored-By: Oz <oz-agent@warp.dev>
…te setter - Drop the redundant suppress_initial_conversation_details_panel_auto_open call inside the remote-child branch of PaneGroup::create_hidden_child_agent_pane; the call is already made by insert_ambient_agent_pane_hidden_for_child_agent one step earlier. - Add a doc comment and move suppress_initial_conversation_details_panel_auto_open (and the cfg(test) test accessor) next to the other conversation-details-panel helpers in TerminalView so they are easier to discover. - Update the spec to describe the single helper-level suppression site. Co-Authored-By: Oz <oz-agent@warp.dev>
Address review feedback on the conversation-details-panel auto-open policy: - Rename the policy variant SuppressInitialAutoOpen to DefaultClosed for clearer pairing with DefaultOpen. - Drop the redundant explanatory comment in create_hidden_child_agent_pane's remote-child branch; the suppression is set inside insert_ambient_agent_pane_hidden_for_child_agent and no longer needs to be called out at the call site. - Update specs/QUALITY-715/TECH.md to use the new variant name. Co-Authored-By: Oz <oz-agent@warp.dev>
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Overview
This PR adds a per-TerminalView policy to consume the first conversation-details auto-open without opening the panel for parent-orchestrated child panes, while preserving the default-open behavior for direct/shared ambient viewers and manual toggles. The implementation is covered by focused unit tests and I did not find code-level or security issues in the changed diff.
Concerns
- This is a user-visible behavior change, but the PR does not include screenshots or a screen recording showing the parent orchestration UI child-open flow and the direct-link/default-open regression behavior. Repo review guidance requires visual evidence for user-facing changes before merge.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
cephalonaut
force-pushed
the
matthew/dont-open-agent-info-sidepane
branch
from
60c6be9 to
bf78886
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Don't auto-open the conversation details side panel when an orchestration child agent is opened from the parent's orchestration UI (pill bar, child status-card reveal, split-off). Direct shared-session links to a child task, ordinary ambient shared-session viewers, and non-shared ambient agent views all keep the current default-open behavior.
The view-level policy lives on
TerminalViewasConversationDetailsPanelAutoOpenPolicy { DefaultOpen, DefaultClosed }and is consulted insidemaybe_auto_open_conversation_details_panelafter the one-shot guard flips. Suppression is applied at the parent-owned child pane materialization sites:PaneGroup::ensure_shared_session_viewer_child_pane(viewer-side shared-session children discovered byOrchestrationViewerModel)PaneGroup::insert_ambient_agent_pane_hidden_for_child_agent(covers both restored remote child panes and freshly-spawned remote children, before environment setup /SessionReadycan fire)Direct shared-session links go through the ordinary viewer path and never set the policy, so they continue to open the panel by default.
Linked Issue
QUALITY-715
Testing
Added unit coverage in
app/src/pane_group/mod_tests.rsandapp/src/terminal/view/shared_session/view_impl_tests.rs:Hidden ambient child pane suppresses initial details auto-open.
Restored remote hidden child pane enters the existing ambient session with suppression applied.
Default ambient shared-session viewer still auto-opens the panel.
A suppressed view still allows manual toggle to open the panel.
Direct child shared-session link keeps the default auto-open.
I have manually tested my changes locally with
./script/runAgent Mode
Conversation: https://staging.warp.dev/conversation/b8de40cd-c347-443d-aafa-1a66bb71685f
Co-Authored-By: Oz oz-agent@warp.dev