don't fork in the cloud for fork-from#11070
Merged
Merged
Conversation
Contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Overview
This PR skips the server-side fork path when the fork is from a specific exchange, leaving the local truncated fork unbound to the cloud copy that would otherwise include later exchanges.
Concerns
- No blocking correctness concerns found in the changed control flow.
- Security pass: no security concerns found.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
captainsafia
approved these changes
May 15, 2026
harryalbert
force-pushed
the
harry/skip-server-side-fork-for-fork-from
branch
from
b601495 to
ed04574
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The fork endpoint doesn't allow you to specify a specific request ID to stop at, and even if it did I don't really think we want to do that (because right now the endpoint just copies all GCS data and calls it a day). To fix this, we should just not fork in the cloud for when we fork from a specific request.
I don't think this feature is used much anyways, and even if it was all this disables is forking from a specific query and then immediately handing off (as opposed to sending one more request and then handing off)
Agent Mode