Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions app/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -601,7 +601,6 @@ default = [
"fork_from_command",
"context_window_usage_v2",
"ambient_agents_command_line",
"ambient_agents_image_upload",
"scheduled_ambient_agents",
"warp_managed_secrets",
"v4a_file_diffs",
Expand Down Expand Up @@ -759,7 +758,6 @@ agent_mode_evals = [
"warp_server_client/agent_mode_evals",
]
ambient_agents_command_line = []
ambient_agents_image_upload = []
scheduled_ambient_agents = []
allow_ignoring_input_suggestions = []
inline_slash_commands = ["agent_view"]
Expand Down
35 changes: 10 additions & 25 deletions app/src/ai/agent_sdk/ambient.rs
Original file line number Diff line number Diff line change
Expand Up @@ -350,33 +350,18 @@ impl AmbientAgentRunner {
return;
}

let attachments = if FeatureFlag::AmbientAgentsImageUpload.is_enabled() {
if !args.attachment_paths.is_empty() {
match args
.attachment_paths
.iter()
.enumerate()
.map(|(i, path)| process_attachment(path, i))
.collect::<Result<Vec<_>, _>>()
{
Ok(processed) => processed,
Err(err) => {
super::report_fatal_error(err, ctx);
return;
}
}
} else {
vec![]
}
} else {
if !args.attachment_paths.is_empty() {
super::report_fatal_error(
anyhow::anyhow!("Attachment upload is not enabled"),
ctx,
);
let attachments = match args
.attachment_paths
.iter()
.enumerate()
.map(|(i, path)| process_attachment(path, i))
.collect::<Result<Vec<_>, _>>()
{
Ok(processed) => processed,
Err(err) => {
super::report_fatal_error(err, ctx);
return;
}
vec![]
};

let mut environment_args = args.environment;
Expand Down
4 changes: 0 additions & 4 deletions app/src/ai/agent_sdk/driver/attachments.rs
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,6 @@ pub(crate) async fn fetch_and_download_attachments(
task_id: String,
attachments_dir: PathBuf,
) -> anyhow::Result<Option<String>> {
if !FeatureFlag::AmbientAgentsImageUpload.is_enabled() {
return Ok(None);
}

let attachments = ai_client
.get_task_attachments(task_id.clone())
.await
Expand Down
2 changes: 0 additions & 2 deletions app/src/features.rs
Original file line number Diff line number Diff line change
Expand Up @@ -275,8 +275,6 @@ fn enabled_features() -> HashSet<FeatureFlag> {
FeatureFlag::AllowIgnoringInputSuggestions,
#[cfg(feature = "ambient_agents_command_line")]
FeatureFlag::AmbientAgentsCommandLine,
#[cfg(feature = "ambient_agents_image_upload")]
FeatureFlag::AmbientAgentsImageUpload,
#[cfg(feature = "scheduled_ambient_agents")]
FeatureFlag::ScheduledAmbientAgents,
#[cfg(feature = "conversation_api")]
Expand Down
3 changes: 0 additions & 3 deletions crates/warp_features/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -653,9 +653,6 @@ pub enum FeatureFlag {
/// Gates populating/reading oz updates from channel versions in the changelog model.
OzChangelogUpdates,

/// Enables image upload for ambient agents.
AmbientAgentsImageUpload,

/// Enables image attachment support for cloud mode conversations.
CloudModeImageContext,

Expand Down
Loading