optimized tests with and without jms serializer

Author: wasinger

.github/workflows/tests.yml

@@ -17,6 +17,8 @@ jobs:
       matrix:
         php: [8.0, 8.1, 8.2, 8.3, 8.4]
         dependency-version: [prefer-lowest, prefer-stable]
+        optional-deps: [without-jms, without-serializer, with-both]
+    name: PHP ${{ matrix.php }} - ${{ matrix.dependency-version }} - ${{ matrix.optional-deps }}
 
     steps:
       - name: checkout code
@@ -28,8 +30,30 @@ jobs:
           php-version: ${{ matrix.php }}
           coverage: xdebug
 
+      - name: get composer cache directory
+        id: composer-cache
+        run: echo "dir=$(composer config cache-files-dir)" >> $GITHUB_OUTPUT
+
+      - name: cache composer dependencies
+        uses: actions/cache@v4
+        with:
+          path: ${{ steps.composer-cache.outputs.dir }}
+          key: ${{ runner.os }}-composer-${{ matrix.php }}-${{ matrix.dependency-version }}-${{ hashFiles('**/composer.lock') }}
+          restore-keys: |
+            ${{ runner.os }}-composer-${{ matrix.php }}-${{ matrix.dependency-version }}-
+            ${{ runner.os }}-composer-${{ matrix.php }}-
+            ${{ runner.os }}-composer-
+
       - name: install dependencies
-        run: composer update --${{ matrix.dependency-version }}
+        run: composer update --${{ matrix.dependency-version }} --no-progress --no-interaction
+
+      - name: remove optional dependency (jms/serializer-bundle)
+        if: matrix.optional-deps == 'without-jms'
+        run: composer remove jms/serializer-bundle --dev --no-progress --no-interaction
+
+      - name: remove optional dependency (symfony/serializer)
+        if: matrix.optional-deps == 'without-serializer'
+        run: composer remove symfony/serializer --dev --no-progress --no-interaction
 
       - name: run tests
         run: php vendor/bin/phpunit

Tests/Fixtures/app/Wa72JsonRpcBundleTestKernel1.php

@@ -19,7 +19,7 @@ public function registerBundles(): iterable
 
     public function registerContainerConfiguration(LoaderInterface $loader): void
     {
-        $loader->load(__DIR__.'/config/config.yml');
+        $loader->load(__DIR__ . '/config/config1.yml');
     }
 
     /**

Tests/Fixtures/app/Wa72JsonRpcBundleTestKernel2.php

@@ -20,7 +20,7 @@ public function registerBundles(): iterable
 
     public function registerContainerConfiguration(LoaderInterface $loader): void
     {
-        $loader->load(__DIR__ . '/config/config.yml');
+        $loader->load(__DIR__ . '/config/config2.yml');
     }
 
 

Tests/Fixtures/app/config/config.yml Tests/Fixtures/app/config/config1.ymlTests/Fixtures/app/config/config.yml renamed to Tests/Fixtures/app/config/config1.yml

@@ -1,7 +1,5 @@
 framework:
   secret: dummy
-  serializer:
-    enabled: true
   property_access:
     enabled: true
 

Tests/Fixtures/app/config/config2.yml

@@ -0,0 +1,20 @@
+framework:
+  secret: dummy
+  serializer:
+    enabled: true
+  property_access:
+    enabled: true
+
+wa72_json_rpc:
+    functions:
+      testhello:
+        service: wa72_jsonrpc.testservice
+        method: hello
+
+services:
+    wa72_jsonrpc.testservice:
+        class: 'Wa72\JsonRpcBundle\Tests\Testservice'
+        public: true
+        tags:
+          - {name: wa72_jsonrpc.exposable}
+

Tests/JsonRpcController1Test.php

@@ -28,12 +28,13 @@ public function setUp(): void
             } else {
                 $this->fail('No serializer available. Please install JMS Serializer Bundle or Symfony Serializer.');
             }
+        } else {
+            $this->kernel = new \Wa72JsonRpcBundleTestKernel1('test', false);
+            $this->kernel->boot();
+            $container = $this->kernel->getContainer();
+            $this->serializer = $container->get('jms_serializer');
+            $this->controller = $container->get('wa72_jsonrpc.jsonrpccontroller');
         }
-        $this->kernel = new \Wa72JsonRpcBundleTestKernel1('test', false);
-        $this->kernel->boot();
-        $container = $this->kernel->getContainer();
-        $this->serializer = $container->get('jms_serializer');
-        $this->controller = $container->get('wa72_jsonrpc.jsonrpccontroller');
     }
 
     public function testHello()

Tests/JsonRpcController2Test.php

@@ -27,12 +27,13 @@ public function setUp(): void
             } else {
                 $this->fail('No serializer available. Please install JMS Serializer Bundle or Symfony Serializer.');
             }
+        } else {
+            $this->kernel = new \Wa72JsonRpcBundleTestKernel2('test', true);
+            $this->kernel->boot();
+            $container = $this->kernel->getContainer();
+            $this->serializer = $container->get('wa72_jsonrpc.serializer');
+            $this->controller = $container->get('wa72_jsonrpc.jsonrpccontroller');
         }
-        $this->kernel = new \Wa72JsonRpcBundleTestKernel2('test', true);
-        $this->kernel->boot();
-        $container = $this->kernel->getContainer();
-        $this->serializer = $container->get('wa72_jsonrpc.serializer');
-        $this->controller = $container->get('wa72_jsonrpc.jsonrpccontroller');
     }
 
     public function testHello()