Update docs for the Rust-generated wasm function#899
Open
epompeii wants to merge 1 commit intowasm-bindgen:masterfrom
Open
Update docs for the Rust-generated wasm function#899epompeii wants to merge 1 commit intowasm-bindgen:masterfrom
epompeii wants to merge 1 commit intowasm-bindgen:masterfrom
Conversation
The documentation is out of date. It says that there should be a `run()` function, but really a `main_js()` function should be there. However, the `rust-webpack-template` doesn't add the `then()` statement to the import in the template. I have created [a pull request](rustwasm/rust-webpack-template#172) to add this to the template, and I have updated the docs for this newer version here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The documentation is out of date. It says that there should be a
run()function, but really amain_js()function should be there.However, the
rust-webpack-templatedoesn't add thethen()statement to the import in the template.I have created a pull request to add this to the template, and I have updated the docs for this newer version here.