Feat: Enhance rule set#4
Merged
Merged
Conversation
Add other already-available rules in sample_eslint_config.mjs
Changqing-JING
requested changes
Jun 4, 2025
HerrCai0907
reviewed
Jun 4, 2025
Changqing-JING
requested changes
Jun 4, 2025
Changqing-JING
requested changes
Jun 5, 2025
…ance is usually determined by specific hardware support)
Changqing-JING
approved these changes
Jun 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces enhancement to the AssemblyScript ESLint plugin, including two new rules (
no-concat-stringandspecify-type) to improve code quality and performance, updating the sample ESLint configuration, and other minor adjustments. Below is a breakdown of specific changes in this PR.New Rules Added:
no-concat-stringRule:array.join()or string builders. [1] [2]specify-typeRule:Plugin Updates:
no-concat-stringandspecify-typeto the plugin's rule set inplugins/asPlugin.ts.tests/asPlugin.test.ts.Sample ESLint Configuration:
sample_config/sample_eslint.config.mjsto use consistent double quotes and added new rules such asno-implicit-globals,curly, and@typescript-eslint/no-restricted-typesto enforce stricter coding practices. [1] [2]Minor Adjustments:
sample_config/**from.prettierignoreto ensure proper formatting of sample configuration files.sonarjsto thetypecheckerincspell/project-words.txt.