Allocate executable JIT code to read+execute memory directly#7
Open
mafone wants to merge 2 commits into
Open
Conversation
- Fix a sensitive transition from read+write to read+execute On QNX, this prevents the acquisition of the prot_write_and_exec ability
mafone
commented
Mar 10, 2026
| int32_t error{ftruncate(jitCodeMapFile, static_cast<off_t>(alignedSize))}; | ||
|
|
||
| if (error != 0) { | ||
| if ((error != 0) || (write(jitCodeMapFile, data, size) == -1)) { |
Author
There was a problem hiding this comment.
Suggested change
| if ((error != 0) || (write(jitCodeMapFile, data, size) == -1)) { | |
| if ((error != 0) || (data == nullptr) || (write(jitCodeMapFile, data, size) == -1)) { |
mafone
commented
Mar 10, 2026
mafone
commented
Mar 13, 2026
| // coverity[autosar_cpp14_a16_2_3_violation] | ||
| static_cast<int32_t>(syscall(__NR_memfd_create, ss.str().c_str(), MFD_CLOEXEC))}; // NOLINT(cppcoreguidelines-pro-type-vararg) | ||
| #elif defined __QNX__ | ||
| int32_t const jitCodeMapFile{SHM_ANON, O_RDWR | O_CREAT, 0600)}; |
Author
There was a problem hiding this comment.
Suggested change
| int32_t const jitCodeMapFile{SHM_ANON, O_RDWR | O_CREAT, 0600)}; | |
| int32_t const jitCodeMapFile{shm_open(SHM_ANON, O_RDWR | O_CREAT, 0600)}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents a sensitive transition from read+write to read+execute