Skip to content

Commit 609460f

Browse files
gumb0axic
authored andcommitted
capi: use size_t for array sizes
1 parent ec46ba8 commit 609460f

4 files changed

Lines changed: 13 additions & 13 deletions

File tree

include/fizzy/fizzy.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ typedef struct FizzyExecutionResult
4747
/// @param args_size Size of the argument array.
4848
/// @param depth Call stack depth.
4949
typedef struct FizzyExecutionResult (*FizzyExternalFn)(void* context,
50-
struct FizzyInstance* instance, const union FizzyValue* args, uint32_t args_size, int depth);
50+
struct FizzyInstance* instance, const union FizzyValue* args, size_t args_size, int depth);
5151

5252
/// External function.
5353
typedef struct FizzyExternalFunction
@@ -78,7 +78,7 @@ void fizzy_free_module(struct FizzyModule* module);
7878
/// @param imported_functions Pointer to the imported function array.
7979
/// @param imported_functions_size Size of the imported function array.
8080
struct FizzyInstance* fizzy_instantiate(struct FizzyModule* module,
81-
const struct FizzyExternalFunction* imported_functions, uint32_t imported_functions_size);
81+
const struct FizzyExternalFunction* imported_functions, size_t imported_functions_size);
8282

8383
/// Free resources associated with the instance.
8484
void fizzy_free_instance(struct FizzyInstance* instance);
@@ -90,7 +90,7 @@ void fizzy_free_instance(struct FizzyInstance* instance);
9090
/// @param args_size Size of the argument array.
9191
/// @param depth Call stack depth.
9292
FizzyExecutionResult fizzy_execute(struct FizzyInstance* instance, uint32_t func_idx,
93-
const union FizzyValue* args, uint32_t args_size, int depth);
93+
const union FizzyValue* args, size_t args_size, int depth);
9494

9595
#ifdef __cplusplus
9696
}

lib/fizzy/capi.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ void fizzy_free_module(FizzyModule* module)
6767
}
6868

6969
FizzyInstance* fizzy_instantiate(FizzyModule* module,
70-
const FizzyExternalFunction* imported_functions, uint32_t imported_functions_size)
70+
const FizzyExternalFunction* imported_functions, size_t imported_functions_size)
7171
{
7272
try
7373
{
@@ -116,7 +116,7 @@ void fizzy_free_instance(FizzyInstance* instance)
116116
}
117117

118118
FizzyExecutionResult fizzy_execute(FizzyInstance* instance, uint32_t func_idx,
119-
const FizzyValue* cargs, uint32_t args_size, int depth)
119+
const FizzyValue* cargs, size_t args_size, int depth)
120120
{
121121
const auto args = reinterpret_cast<const fizzy::Value*>(cargs);
122122

test/compilation/compilation_test.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ bool validate(const uint8_t* binary, size_t size);
88
bool parse(const uint8_t* binary, size_t size);
99
bool instantiate(const uint8_t* binary, size_t size);
1010
struct FizzyExecutionResult dummy_host_func(void* context, struct FizzyInstance* instance,
11-
const union FizzyValue* args, uint32_t args_size, int depth);
11+
const union FizzyValue* args, size_t args_size, int depth);
1212
bool instantiate_with_host_func(const uint8_t* binary, size_t size);
1313
bool execute(const uint8_t* binary, size_t size);
1414

@@ -42,7 +42,7 @@ bool instantiate(const uint8_t* binary, size_t size)
4242
}
4343

4444
struct FizzyExecutionResult dummy_host_func(void* context, struct FizzyInstance* instance,
45-
const union FizzyValue* args, uint32_t args_size, int depth)
45+
const union FizzyValue* args, size_t args_size, int depth)
4646
{
4747
(void)context;
4848
(void)instance;

test/unittests/capi_test.cpp

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ TEST(capi, instantiate_imported_function)
5454
EXPECT_NE(module, nullptr);
5555

5656
FizzyExternalFunction host_funcs[] = {
57-
{[](void*, FizzyInstance*, const FizzyValue*, uint32_t, int) {
57+
{[](void*, FizzyInstance*, const FizzyValue*, size_t, int) {
5858
return FizzyExecutionResult{false, true, {42}};
5959
},
6060
nullptr}};
@@ -107,11 +107,11 @@ TEST(capi, execute_with_host_function)
107107
EXPECT_NE(module, nullptr);
108108

109109
FizzyExternalFunction host_funcs[] = {
110-
{[](void*, FizzyInstance*, const FizzyValue*, uint32_t, int) {
110+
{[](void*, FizzyInstance*, const FizzyValue*, size_t, int) {
111111
return FizzyExecutionResult{false, true, {42}};
112112
},
113113
nullptr},
114-
{[](void*, FizzyInstance*, const FizzyValue* args, uint32_t, int) {
114+
{[](void*, FizzyInstance*, const FizzyValue* args, size_t, int) {
115115
return FizzyExecutionResult{false, true, {args[0].i64 / args[1].i64}};
116116
},
117117
nullptr}};
@@ -141,7 +141,7 @@ TEST(capi, imported_function_traps)
141141
EXPECT_NE(module, nullptr);
142142

143143
FizzyExternalFunction host_funcs[] = {
144-
{[](void*, FizzyInstance*, const FizzyValue*, uint32_t, int) {
144+
{[](void*, FizzyInstance*, const FizzyValue*, size_t, int) {
145145
return FizzyExecutionResult{true, false, {}};
146146
},
147147
nullptr}};
@@ -169,7 +169,7 @@ TEST(capi, imported_function_void)
169169

170170
bool called = false;
171171
FizzyExternalFunction host_funcs[] = {
172-
{[](void* context, FizzyInstance*, const FizzyValue*, uint32_t, int) {
172+
{[](void* context, FizzyInstance*, const FizzyValue*, size_t, int) {
173173
*static_cast<bool*>(context) = true;
174174
return FizzyExecutionResult{false, false, {}};
175175
},
@@ -221,7 +221,7 @@ TEST(capi, imported_function_from_another_module)
221221

222222
// TODO fizzy_find_exported_function
223223

224-
auto sub = [](void* context, FizzyInstance*, const FizzyValue* args, uint32_t args_size,
224+
auto sub = [](void* context, FizzyInstance*, const FizzyValue* args, size_t args_size,
225225
int depth) -> FizzyExecutionResult {
226226
auto* called_instance = static_cast<FizzyInstance*>(context);
227227
return fizzy_execute(called_instance, 0, args, args_size, depth + 1);

0 commit comments

Comments
 (0)