Skip to content

Commit 370ac3c

Browse files
jeff-arnjeff-arn
committed
fix(hand edit): remove trainingStatus from CreateCollection and UpdateCollection
these are output parameters and should not be generated in the options model
1 parent d9f1822 commit 370ac3c

2 files changed

Lines changed: 2 additions & 34 deletions

File tree

‎visualrecognitionv4/visual_recognition_v4.go‎

Lines changed: 2 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -281,9 +281,7 @@ func (visualRecognition *VisualRecognitionV4) CreateCollectionWithContext(ctx co
281281
if createCollectionOptions.Description != nil {
282282
body["description"] = createCollectionOptions.Description
283283
}
284-
if createCollectionOptions.TrainingStatus != nil {
285-
body["training_status"] = createCollectionOptions.TrainingStatus
286-
}
284+
287285
_, err = builder.SetBodyContentJSON(body)
288286
if err != nil {
289287
return
@@ -472,9 +470,7 @@ func (visualRecognition *VisualRecognitionV4) UpdateCollectionWithContext(ctx co
472470
if updateCollectionOptions.Description != nil {
473471
body["description"] = updateCollectionOptions.Description
474472
}
475-
if updateCollectionOptions.TrainingStatus != nil {
476-
body["training_status"] = updateCollectionOptions.TrainingStatus
477-
}
473+
478474
_, err = builder.SetBodyContentJSON(body)
479475
if err != nil {
480476
return
@@ -1768,9 +1764,6 @@ type CreateCollectionOptions struct {
17681764
// The description of the collection.
17691765
Description *string `json:"description,omitempty"`
17701766

1771-
// Training status information for the collection.
1772-
TrainingStatus *TrainingStatus `json:"training_status,omitempty"`
1773-
17741767
// Allows users to set headers on API requests
17751768
Headers map[string]string
17761769
}
@@ -1792,12 +1785,6 @@ func (options *CreateCollectionOptions) SetDescription(description string) *Crea
17921785
return options
17931786
}
17941787

1795-
// SetTrainingStatus : Allow user to set TrainingStatus
1796-
func (options *CreateCollectionOptions) SetTrainingStatus(trainingStatus *TrainingStatus) *CreateCollectionOptions {
1797-
options.TrainingStatus = trainingStatus
1798-
return options
1799-
}
1800-
18011788
// SetHeaders : Allow user to set Headers
18021789
func (options *CreateCollectionOptions) SetHeaders(param map[string]string) *CreateCollectionOptions {
18031790
options.Headers = param
@@ -3097,9 +3084,6 @@ type UpdateCollectionOptions struct {
30973084
// The description of the collection.
30983085
Description *string `json:"description,omitempty"`
30993086

3100-
// Training status information for the collection.
3101-
TrainingStatus *TrainingStatus `json:"training_status,omitempty"`
3102-
31033087
// Allows users to set headers on API requests
31043088
Headers map[string]string
31053089
}
@@ -3129,12 +3113,6 @@ func (options *UpdateCollectionOptions) SetDescription(description string) *Upda
31293113
return options
31303114
}
31313115

3132-
// SetTrainingStatus : Allow user to set TrainingStatus
3133-
func (options *UpdateCollectionOptions) SetTrainingStatus(trainingStatus *TrainingStatus) *UpdateCollectionOptions {
3134-
options.TrainingStatus = trainingStatus
3135-
return options
3136-
}
3137-
31383116
// SetHeaders : Allow user to set Headers
31393117
func (options *UpdateCollectionOptions) SetHeaders(param map[string]string) *UpdateCollectionOptions {
31403118
options.Headers = param

‎visualrecognitionv4/visual_recognition_v4_test.go‎

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -489,7 +489,6 @@ var _ = Describe(`VisualRecognitionV4`, func() {
489489
createCollectionOptionsModel := new(visualrecognitionv4.CreateCollectionOptions)
490490
createCollectionOptionsModel.Name = core.StringPtr("testString")
491491
createCollectionOptionsModel.Description = core.StringPtr("testString")
492-
createCollectionOptionsModel.TrainingStatus = trainingStatusModel
493492
createCollectionOptionsModel.Headers = map[string]string{"x-custom-header": "x-custom-value"}
494493
// Expect response parsing to fail since we are receiving a text/plain response
495494
result, response, operationErr := visualRecognitionService.CreateCollection(createCollectionOptionsModel)
@@ -584,7 +583,6 @@ var _ = Describe(`VisualRecognitionV4`, func() {
584583
createCollectionOptionsModel := new(visualrecognitionv4.CreateCollectionOptions)
585584
createCollectionOptionsModel.Name = core.StringPtr("testString")
586585
createCollectionOptionsModel.Description = core.StringPtr("testString")
587-
createCollectionOptionsModel.TrainingStatus = trainingStatusModel
588586
createCollectionOptionsModel.Headers = map[string]string{"x-custom-header": "x-custom-value"}
589587

590588
// Invoke operation with valid options model (positive test)
@@ -644,7 +642,6 @@ var _ = Describe(`VisualRecognitionV4`, func() {
644642
createCollectionOptionsModel := new(visualrecognitionv4.CreateCollectionOptions)
645643
createCollectionOptionsModel.Name = core.StringPtr("testString")
646644
createCollectionOptionsModel.Description = core.StringPtr("testString")
647-
createCollectionOptionsModel.TrainingStatus = trainingStatusModel
648645
createCollectionOptionsModel.Headers = map[string]string{"x-custom-header": "x-custom-value"}
649646
// Invoke operation with empty URL (negative test)
650647
err := visualRecognitionService.SetServiceURL("")
@@ -1017,7 +1014,6 @@ var _ = Describe(`VisualRecognitionV4`, func() {
10171014
updateCollectionOptionsModel.CollectionID = core.StringPtr("testString")
10181015
updateCollectionOptionsModel.Name = core.StringPtr("testString")
10191016
updateCollectionOptionsModel.Description = core.StringPtr("testString")
1020-
updateCollectionOptionsModel.TrainingStatus = trainingStatusModel
10211017
updateCollectionOptionsModel.Headers = map[string]string{"x-custom-header": "x-custom-value"}
10221018
// Expect response parsing to fail since we are receiving a text/plain response
10231019
result, response, operationErr := visualRecognitionService.UpdateCollection(updateCollectionOptionsModel)
@@ -1113,7 +1109,6 @@ var _ = Describe(`VisualRecognitionV4`, func() {
11131109
updateCollectionOptionsModel.CollectionID = core.StringPtr("testString")
11141110
updateCollectionOptionsModel.Name = core.StringPtr("testString")
11151111
updateCollectionOptionsModel.Description = core.StringPtr("testString")
1116-
updateCollectionOptionsModel.TrainingStatus = trainingStatusModel
11171112
updateCollectionOptionsModel.Headers = map[string]string{"x-custom-header": "x-custom-value"}
11181113

11191114
// Invoke operation with valid options model (positive test)
@@ -1174,7 +1169,6 @@ var _ = Describe(`VisualRecognitionV4`, func() {
11741169
updateCollectionOptionsModel.CollectionID = core.StringPtr("testString")
11751170
updateCollectionOptionsModel.Name = core.StringPtr("testString")
11761171
updateCollectionOptionsModel.Description = core.StringPtr("testString")
1177-
updateCollectionOptionsModel.TrainingStatus = trainingStatusModel
11781172
updateCollectionOptionsModel.Headers = map[string]string{"x-custom-header": "x-custom-value"}
11791173
// Invoke operation with empty URL (negative test)
11801174
err := visualRecognitionService.SetServiceURL("")
@@ -3927,12 +3921,10 @@ var _ = Describe(`VisualRecognitionV4`, func() {
39273921
createCollectionOptionsModel := visualRecognitionService.NewCreateCollectionOptions()
39283922
createCollectionOptionsModel.SetName("testString")
39293923
createCollectionOptionsModel.SetDescription("testString")
3930-
createCollectionOptionsModel.SetTrainingStatus(trainingStatusModel)
39313924
createCollectionOptionsModel.SetHeaders(map[string]string{"foo": "bar"})
39323925
Expect(createCollectionOptionsModel).ToNot(BeNil())
39333926
Expect(createCollectionOptionsModel.Name).To(Equal(core.StringPtr("testString")))
39343927
Expect(createCollectionOptionsModel.Description).To(Equal(core.StringPtr("testString")))
3935-
Expect(createCollectionOptionsModel.TrainingStatus).To(Equal(trainingStatusModel))
39363928
Expect(createCollectionOptionsModel.Headers).To(Equal(map[string]string{"foo": "bar"}))
39373929
})
39383930
It(`Invoke NewDeleteCollectionOptions successfully`, func() {
@@ -4156,13 +4148,11 @@ var _ = Describe(`VisualRecognitionV4`, func() {
41564148
updateCollectionOptionsModel.SetCollectionID("testString")
41574149
updateCollectionOptionsModel.SetName("testString")
41584150
updateCollectionOptionsModel.SetDescription("testString")
4159-
updateCollectionOptionsModel.SetTrainingStatus(trainingStatusModel)
41604151
updateCollectionOptionsModel.SetHeaders(map[string]string{"foo": "bar"})
41614152
Expect(updateCollectionOptionsModel).ToNot(BeNil())
41624153
Expect(updateCollectionOptionsModel.CollectionID).To(Equal(core.StringPtr("testString")))
41634154
Expect(updateCollectionOptionsModel.Name).To(Equal(core.StringPtr("testString")))
41644155
Expect(updateCollectionOptionsModel.Description).To(Equal(core.StringPtr("testString")))
4165-
Expect(updateCollectionOptionsModel.TrainingStatus).To(Equal(trainingStatusModel))
41664156
Expect(updateCollectionOptionsModel.Headers).To(Equal(map[string]string{"foo": "bar"}))
41674157
})
41684158
It(`Invoke NewUpdateObjectMetadata successfully`, func() {

0 commit comments

Comments
 (0)