Skip to content

Commit 66773bd

Browse files
committed
refactor(core): Only expose getToken method in IamTokenManager
1 parent 772ae6a commit 66773bd

File tree

2 files changed

+3
-33
lines changed

2 files changed

+3
-33
lines changed

core/src/main/java/com/ibm/watson/developer_cloud/service/security/IamTokenManager.java

Lines changed: 2 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ public String getToken() {
8585
*
8686
* @return the new access token
8787
*/
88-
public String requestToken() {
88+
private String requestToken() {
8989
RequestBuilder builder = RequestBuilder.post(RequestBuilder.constructHttpUrl(url, new String[0]));
9090

9191
builder.header(HttpHeaders.CONTENT_TYPE, HttpMediaType.APPLICATION_FORM_URLENCODED);
@@ -107,7 +107,7 @@ public String requestToken() {
107107
*
108108
* @return the new access token
109109
*/
110-
public String refreshToken() {
110+
private String refreshToken() {
111111
RequestBuilder builder = RequestBuilder.post(RequestBuilder.constructHttpUrl(url, new String[0]));
112112

113113
builder.header(HttpHeaders.CONTENT_TYPE, HttpMediaType.APPLICATION_FORM_URLENCODED);
@@ -123,20 +123,6 @@ public String refreshToken() {
123123
return tokenData.getAccessToken();
124124
}
125125

126-
/**
127-
* Set a self-managed IAM access token.
128-
* The access token should be valid and not yet expired.
129-
*
130-
* By using this method, you accept responsibility for managing the access token yourself. You must set a new
131-
* access token before this one expires. Failing to do so will result in authentication errors after this token
132-
* expires.
133-
*
134-
* @param userManagedAccessToken a valid, non-expired IAM access token
135-
*/
136-
public void setAccessToken(String userManagedAccessToken) {
137-
this.userManagedAccessToken = userManagedAccessToken;
138-
}
139-
140126
/**
141127
* Check if currently stored access token is expired.
142128
*

core/src/test/java/com/ibm/watson/developer_cloud/service/IamManagerTest.java

Lines changed: 1 addition & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
import com.ibm.watson.developer_cloud.service.security.IamTokenManager;
1919
import org.junit.Before;
2020
import org.junit.Test;
21+
2122
import static org.junit.Assert.assertEquals;
2223

2324
public class IamManagerTest extends WatsonServiceUnitTest {
@@ -54,23 +55,6 @@ public void getUserManagedTokenFromConstructor() {
5455
assertEquals(ACCESS_TOKEN, token);
5556
}
5657

57-
/**
58-
* Tests that if a user sets their own access token at some point, that access token gets passed back during later
59-
* retrieval.
60-
*/
61-
@Test
62-
public void getUserManagedTokenFromMethodCall() {
63-
IamOptions options = new IamOptions.Builder()
64-
.apiKey(API_KEY)
65-
.url(url)
66-
.build();
67-
IamTokenManager manager = new IamTokenManager(options);
68-
manager.setAccessToken(ACCESS_TOKEN);
69-
70-
String token = manager.getToken();
71-
assertEquals(ACCESS_TOKEN, token);
72-
}
73-
7458
/**
7559
* Tests that if only an API key is stored, the user can get back a valid access token.
7660
*/

0 commit comments

Comments
 (0)