Skip to content

Commit 03c8bac

Browse files
committed
fix: minor change to incorrect generated code
fix: minor change to incorrect generated code
1 parent a2a4cd1 commit 03c8bac

2 files changed

Lines changed: 12 additions & 18 deletions

File tree

lib/ibm_watson/visual_recognition_v3.rb

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ module IBMWatson
3030
# The Visual Recognition V3 service.
3131
class VisualRecognitionV3 < IBMCloudSdkCore::BaseService
3232
include Concurrent::Async
33-
DEFAULT_SERVICE_NAME = "watson_vision_combined"
33+
DEFAULT_SERVICE_NAME = "visual_recognition"
3434
DEFAULT_SERVICE_URL = "https://gateway.watsonplatform.net/visual-recognition/api"
3535
##
3636
# @!method initialize(args)
@@ -132,19 +132,16 @@ def classify(images_file: nil, images_filename: nil, images_file_content_type: n
132132
form_data[:images_file] = HTTP::FormData::File.new(images_file, content_type: images_file_content_type.nil? ? "application/octet-stream" : images_file_content_type, filename: images_filename)
133133
end
134134

135+
classifier_ids *= "," unless classifier_ids.nil?
136+
owners *= "," unless owners.nil?
137+
135138
form_data[:url] = HTTP::FormData::Part.new(url.to_s, content_type: "text/plain") unless url.nil?
136139

137140
form_data[:threshold] = HTTP::FormData::Part.new(threshold.to_s, content_type: "application/json") unless threshold.nil?
138141

139-
form_data[:owners] = []
140-
owners&.each do |item|
141-
form_data[:owners].push(HTTP::FormData::Part.new(item.to_s, content_type: "text/plain"))
142-
end
142+
form_data[:owners] = HTTP::FormData::Part.new(owners, content_type: "application/json") unless owners.nil?
143143

144-
form_data[:classifier_ids] = []
145-
classifier_ids&.each do |item|
146-
form_data[:classifier_ids].push(HTTP::FormData::Part.new(item.to_s, content_type: "text/plain"))
147-
end
144+
form_data[:classifier_ids] = HTTP::FormData::Part.new(classifier_ids, content_type: "application/json") unless classifier_ids.nil?
148145

149146
method_url = "/v3/classify"
150147

lib/ibm_watson/visual_recognition_v4.rb

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ module IBMWatson
2929
# The Visual Recognition V4 service.
3030
class VisualRecognitionV4 < IBMCloudSdkCore::BaseService
3131
include Concurrent::Async
32-
DEFAULT_SERVICE_NAME = "watson_vision_combined"
32+
DEFAULT_SERVICE_NAME = "visual_recognition"
3333
DEFAULT_SERVICE_URL = "https://gateway.watsonplatform.net/visual-recognition/api"
3434
##
3535
# @!method initialize(args)
@@ -116,15 +116,12 @@ def analyze(collection_ids:, features:, images_file: nil, image_url: nil, thresh
116116

117117
form_data = {}
118118

119-
form_data[:collection_ids] = []
120-
collection_ids&.each do |item|
121-
form_data[:collection_ids].push(HTTP::FormData::Part.new(item.to_s, content_type: "text/plain"))
122-
end
119+
collection_ids *= "," unless collection_ids.nil?
120+
features *= "," unless features.nil?
123121

124-
form_data[:features] = []
125-
features&.each do |item|
126-
form_data[:features].push(HTTP::FormData::Part.new(item.to_s, content_type: "text/plain"))
127-
end
122+
form_data[:collection_ids] = HTTP::FormData::Part.new(collection_ids.to_s, content_type: "text/plain")
123+
124+
form_data[:features] = HTTP::FormData::Part.new(features.to_s, content_type: "text/plain")
128125

129126
form_data[:images_file] = []
130127
images_file&.each do |item|

0 commit comments

Comments
 (0)