Some more metrics#8
Open
Lanjelin wants to merge 17 commits into
Open
Conversation
elapsed_time_hms, moving_time_hms, distance_km, distance_mile, average_heart_rate, gear_name, pace, pace_mile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hoping you accept pull requests, I've added a few more metrics.
These are available both in csv imports and activity sync.
I've not updated any tests for these new metrics.
Update README for newly added features.
feat: add gear_name
feat: add pace
feat: add pace_mile
feat: add distance_km
feat: add distance_mile
feat: helper turning seconds into HH:mm:ss
feat: add elapsed_time_hms
feat: add moving_time_hms
feat: add average_heart_rate
feat: add ActivityMetrics with pace helpers and formatter
fix: CSV Max Speed to 3 decmal places, matching api
fix: CSV Average speed to 3 decimal places, matching api
fix: gear_name safe fetching
fix: Was missing Activity Gear in REQUIRED_COLUMS
fix: reoder for consistency