Apply review suggestions

Author: coolreader18

lib/LocalEchoController.js

@@ -36,10 +36,17 @@ export default class LocalEchoController {
     this._cursor = 0;
     this._activePrompt = null;
     this._activeCharPrompt = null;
+    this._termSize = {
+      cols: 0,
+      rows: 0,
+    };
 
     this._disposables = [];
 
-    if (term) this.attach();
+    if (term) {
+      if (term.loadAddon) term.loadAddon(this);
+      else this.attach();
+    }
   }
 
   // xterm.js new plugin API:
@@ -59,16 +66,26 @@ export default class LocalEchoController {
    *  Detach the controller from the terminal
    */
   detach() {
-    this._disposables.forEach(d => d.dispose());
-    this._disposables = [];
+    if (this.term.off) {
+      this.term.off("data", this._handleTermData);
+      this.term.off("resize", this._handleTermResize);
+    } else {
+      this._disposables.forEach(d => d.dispose());
+      this._disposables = [];
+    }
   }
 
   /**
    * Attach controller to the terminal, handling events
    */
   attach() {
-    this._disposables.push(this.term.onData(this._handleTermData));
-    this._disposables.push(this.term.onResize(this._handleTermResize));
+    if (this.term.on) {
+      this.term.on("data", this._handleTermData);
+      this.term.on("resize", this._handleTermResize);
+    } else {
+      this._disposables.push(this.term.onData(this._handleTermData));
+      this._disposables.push(this.term.onResize(this._handleTermResize));
+    }
     this._termSize = {
       cols: this.term.cols,
       rows: this.term.rows,