Proto tx messages deduplicator

[nickeskov]

This pull request introduces a message deduplication mechanism for peer.ProtoMessage objects, refactors message handling in the Node class, and adds tests to ensure the correctness of the new functionality. The changes aim to improve efficiency by filtering out duplicate transaction messages and simplifying the internal metrics tracking.

Message Deduplication and Filtering:

• pkg/node/helpers.go: Added safeMap for thread-safe storage and deduplication of messages, and implemented deduplicateProtoMessages and deduplicateProtoTxMessages functions to filter duplicate transaction messages using a message ID filter based on its payloads. These functions ensure that only unique transaction messages are processed while bypassing non-transaction messages.

Refactoring in Node:

• pkg/node/node.go: Updated the Run method to use the new deduplication mechanism (deduplicateProtoTxMessages) for processing peer.ProtoMessage objects. This refactor replaces chanLenProvider with aggregatedLenProvider for improved metrics tracking. [1] [2] [3]

Testing:

• pkg/node/helpers_internal_test.go: Added unit tests for deduplicateProtoTxMessages to verify that duplicate transaction messages are filtered out while non-transaction messages remain unaffected. The tests use mock data and assertions to ensure correctness.

Minor Improvements:

• pkg/p2p/peer/handle.go: Added a clarifying comment to explain the behavior of context cancellation in the Handle function.

[Copilot]

Pull Request Overview

This pull request introduces a message deduplication mechanism for transaction-related proto messages, refactors message handling in the Node, and adds tests to ensure the correctness of the new behavior.

• Introduces a thread‑safe map (safeMap) and payload filtering logic in pkg/node/helpers.go.
• Updates the Node Run method in pkg/node/node.go to utilize the new deduplication mechanism.
• Adds unit tests in pkg/node/helpers_internal_test.go to verify deduplication of duplicate transaction messages.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File	Description
pkg/p2p/peer/handle.go	Added a clarifying comment regarding context cancellation.
pkg/node/node.go	Refactored to use deduplicateProtoTxMessages and updated metrics.
pkg/node/helpers_internal_test.go	Introduced unit tests for deduplication functionality.
pkg/node/helpers.go	Implemented safeMap and deduplication support; potential issue noted.

Comments suppressed due to low confidence (1)

pkg/node/helpers.go:188

• The 'max' function appears to be used without a definition or import. Please ensure that 'max' is defined or replace it with an appropriate alternative for determining the channel buffer size.

	filteredChan := make(chan protoMessageWrapper, max(cap(origMessageCh)-noFilteredChanSize, noFilteredChanSize))