Add support for Unicode digit normalization in string to Int and BigI…#2093
Merged
Conversation
…nt conversion. Added conversion of Unicode decimal digits to ASCII digits and integrated it into Ride functions parseInt, parseIntValued, stringToBigInt, and stringToBigIntOpt. Test added and updated.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Unicode decimal digit normalization for Ride string-to-number conversions, so supported non-ASCII decimal digits can be parsed as ASCII digits.
Changes:
- Adds digit normalization helpers for Unicode decimal digit ranges.
- Integrates normalization into
parseIntand BigInt string parsing. - Expands tests for Unicode digit inputs.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
pkg/ride/functions_strings.go |
Adds digit normalization and applies it to parseInt. |
pkg/ride/functions_strings_test.go |
Adds Unicode digit cases for parseInt and normalization tests. |
pkg/ride/functions_bigint.go |
Applies digit normalization to stringToBigInt. |
pkg/ride/functions_bigint_test.go |
Adds Unicode digit cases for BigInt conversion functions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| return 0, false | ||
| } | ||
|
|
||
| // isMathematicalStyleDigit returns true for Mathematical Alphanumeric Symbols like 𝟎-𝟗, 𝟘-𝟡, 𝟢-𝟫, 𝟬-𝟵, 𝟶-𝟿. |
irina-pereiaslavskaia
previously approved these changes
May 18, 2026
irina-pereiaslavskaia
had a problem deploying
to
ITests
GitHub Actions
Error
nickeskov
temporarily deployed
to
Deploy-mainnet-amd64
GitHub Actions
Inactive
nickeskov
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…nt conversion.
Added conversion of Unicode decimal digits to ASCII digits and integrated it into Ride functions parseInt, parseIntValued, stringToBigInt, and stringToBigIntOpt. Test added and updated.