Merge pull request #96 from wavesplatform/github-workflow

fix workflow and tests

Author: vgakhramanov

.github/workflows/publish.yml

@@ -10,20 +10,21 @@ permissions:
     id-token: write
 jobs:
     publish-snapshots:
+        name: Publish snapshot packages
+        runs-on: ubuntu-latest
         env:
             NODE_OPTIONS: --openssl-legacy-provider
+            TAG: snapshot
         environment:
             name: NPMJS
             url: ${{ steps.publish.outputs.url }}
-        name: Publish snapshot packages
-        runs-on: ubuntu-latest
         steps:
             - uses: actions/checkout@v4
             - uses: actions/setup-node@v4
               with:
                   registry-url: 'https://registry.npmjs.org'
                   node-version: '>=24.7.0'
-            - run: npm i
+            - run: npm ci
             - if: ${{ github.event_name == 'push' }}
               run: |
                   PACKAGE_NAME=$(jq --raw-output .name package.json)
@@ -41,5 +42,6 @@ jobs:
             - id: publish
               run: |
                   npm run build
+                  echo "Publishing version=$(jq -r .version package.json) tag=$TAG"
                   npm publish --provenance --access public --tag $TAG
                   echo "url=https://www.npmjs.com/package/@waves/signer/v/$(jq --raw-output .version package.json)" >> "$GITHUB_OUTPUT"

src/validation.ts

@@ -190,7 +190,8 @@ export const sponsorshipArgsScheme = {
     ...getCommonValidators(TRANSACTION_TYPE.SPONSORSHIP),
     // TODO Add not WAVES ASSET ID
     assetId: isString,
-    minSponsoredAssetFee: isNumberLike,
+    minSponsoredAssetFee: (value: unknown) =>
+        value === null || isNumberLike(value),
 };
 export const sponsorshipArgsValidator = validator(
     sponsorshipArgsScheme as any,

test/TestProvider.ts

@@ -12,7 +12,7 @@ import {
     TypedData,
     UserData,
 } from '../src';
-import { TRANSACTION_TYPE } from '@waves/waves-transactions/dist/transactions';
+import { TRANSACTION_TYPE } from '@waves/ts-types';
 
 export class TestProvider implements Provider {
     private options: ConnectOptions = {
@@ -92,14 +92,20 @@ export class TestProvider implements Provider {
             tx.type === TRANSACTION_TYPE.ALIAS
                 ? { ...tx, alias: tx.alias.replace(/alias:.:/, '') }
                 : tx;
+        const fixIssueDescription = (tx: any) =>
+            tx.type === TRANSACTION_TYPE.ISSUE && tx.description == null
+                ? { ...tx, description: '' }
+                : tx;
 
         return Promise.resolve(
             list.map((item) =>
                 signTx(
-                    fixAlias({
-                        chainId: this.options.NETWORK_BYTE,
-                        ...item,
-                    }) as any,
+                    fixIssueDescription(
+                        fixAlias({
+                            chainId: this.options.NETWORK_BYTE,
+                            ...item,
+                        })
+                    ) as any,
                     this.seed
                 )
             )

test/transactions/alias.spec.ts

@@ -3,7 +3,7 @@ import Signer from '../../src/Signer';
 import { TestProvider } from '../TestProvider';
 import { MASTER_ACCOUNT_SEED } from '@waves/node-state/dist/constants';
 
-let waves: Signer = new Signer();
+let waves: Signer;
 let provider: TestProvider = new TestProvider(MASTER_ACCOUNT_SEED);
 
 

test/transactions/data.spec.ts

@@ -4,7 +4,7 @@ import { TestProvider } from '../TestProvider';
 import { MASTER_ACCOUNT_SEED } from '@waves/node-state/dist/constants';
 
 
-let waves: Signer = new Signer();
+let waves: Signer;
 let provider: TestProvider = new TestProvider(MASTER_ACCOUNT_SEED);
 
 

test/transactions/leasing.spec.ts

@@ -5,7 +5,7 @@ import { libs } from '@waves/waves-transactions';
 
 
 const MASTER_ADDRESS = libs.crypto.address(ACCOUNTS.NODE.seed, NETWORK_BYTE);
-let waves: Signer = new Signer();
+let waves: Signer;
 let provider: TestProvider = new TestProvider(ACCOUNTS.SIMPLE.seed);
 
 

test/transactions/sponsorship.spec.ts

@@ -40,7 +40,7 @@ it('Cancel Sponsorship', async () => {
     await waves
         .sponsorship({
             assetId: asset.id,
-            minSponsoredAssetFee: 0
+            minSponsoredAssetFee: null
         })
         .broadcast();
 });

test/transactions/tokens.spec.ts

@@ -4,7 +4,7 @@ import { TestProvider } from '../TestProvider';
 import { MASTER_ACCOUNT_SEED } from '@waves/node-state/dist/constants';
 
 
-let waves: Signer = new Signer();
+let waves: Signer;
 let provider: TestProvider = new TestProvider(MASTER_ACCOUNT_SEED);
 
 

test/transactions/transfers.spec.ts

@@ -3,9 +3,8 @@ import Signer from '../../src/Signer';
 import { TestProvider } from '../TestProvider';
 import { libs } from '@waves/waves-transactions';
 
-
 const MASTER_ADDRESS = libs.crypto.address(ACCOUNTS.SIMPLE.seed, NETWORK_BYTE);
-let waves: Signer = new Signer();
+let waves: Signer;
 let provider: TestProvider = new TestProvider(ACCOUNTS.SIMPLE.seed);
 
 beforeEach(() => {
@@ -24,11 +23,13 @@ it('Transfer Signer', async () => {
 });
 
 it('Transfer custom asset', async () => {
-    const [{ id }] = await waves.issue({
-        name: 'Bitcoin',
-        decimals: 8,
-        quantity: 10000,
-    }).broadcast();
+    const [{ id }] = await waves
+        .issue({
+            name: 'Bitcoin',
+            decimals: 8,
+            quantity: 10000,
+        })
+        .broadcast();
 
     await waves
         .transfer({
@@ -40,11 +41,13 @@ it('Transfer custom asset', async () => {
 });
 
 it('Transfer two transactions', async () => {
-    const [{ id }] = await waves.issue({
-        name: 'Bitcoin',
-        decimals: 8,
-        quantity: 10000,
-    }).broadcast();
+    const [{ id }] = await waves
+        .issue({
+            name: 'Bitcoin',
+            decimals: 8,
+            quantity: 10000,
+        })
+        .broadcast();
 
     await waves
         .transfer({
@@ -61,11 +64,13 @@ it('Transfer two transactions', async () => {
 });
 
 it('Transfer smart asset', async () => {
-    const [{ id }] = await waves.issue({
-        name: 'Bitcoin',
-        decimals: 8,
-        quantity: 10000,
-    }).broadcast();
+    const [{ id }] = await waves
+        .issue({
+            name: 'Bitcoin',
+            decimals: 8,
+            quantity: 10000,
+        })
+        .broadcast();
 
     const [tx] = await waves
         .transfer({
@@ -82,26 +87,26 @@ it('Transfer smart asset', async () => {
 it('Mass transfer Signer', async () => {
     await waves
         .massTransfer({
-            transfers: [
-                { recipient: MASTER_ADDRESS, amount: Math.pow(10, 8) }
-            ],
+            transfers: [{ recipient: MASTER_ADDRESS, amount: Math.pow(10, 8) }],
+            attachment: null,
         })
         .broadcast();
 });
 
 it('Mass transfer asset', async () => {
-    const [{ id }] = await waves.issue({
-        name: 'Bitcoin',
-        decimals: 8,
-        quantity: 10000,
-    }).broadcast();
+    const [{ id }] = await waves
+        .issue({
+            name: 'Bitcoin',
+            decimals: 8,
+            quantity: 10000,
+        })
+        .broadcast();
 
     await waves
         .massTransfer({
             assetId: id,
-            transfers: [
-                { recipient: MASTER_ADDRESS, amount: Math.pow(10, 8) },
-            ],
+            transfers: [{ recipient: MASTER_ADDRESS, amount: Math.pow(10, 8) }],
+            attachment: null,
         })
         .broadcast();
 });