minor updates

Author: sawka

cmd/wsh/cmd/wshcmd-connserver.go

@@ -247,7 +247,6 @@ func askForJwtToken() (string, error) {
 
 func serverRun(cmd *cobra.Command, args []string) error {
 	var logFile *os.File
-	logWriter := io.Writer(os.Stderr)
 	if connServerDev {
 		var err error
 		logFile, err = os.OpenFile("/tmp/connserver.log", os.O_CREATE|os.O_WRONLY|os.O_APPEND, 0644)
@@ -257,7 +256,7 @@ func serverRun(cmd *cobra.Command, args []string) error {
 			log.SetPrefix(fmt.Sprintf("[PID:%d] ", os.Getpid()))
 		} else {
 			defer logFile.Close()
-			logWriter = io.MultiWriter(os.Stderr, logFile)
+			logWriter := io.MultiWriter(os.Stderr, logFile)
 			log.SetOutput(logWriter)
 			log.SetFlags(log.LstdFlags | log.Lmicroseconds)
 			log.SetPrefix(fmt.Sprintf("[PID:%d] ", os.Getpid()))

cmd/wsh/cmd/wshcmd-root.go

@@ -161,7 +161,10 @@ func setupRpcClient(serverImpl wshutil.ServerImpl, jwtToken string) error {
 	if err != nil {
 		return fmt.Errorf("error setting up domain socket rpc client: %v", err)
 	}
-	wshclient.AuthenticateCommand(RpcClient, jwtToken, &wshrpc.RpcOpts{Route: wshutil.ControlRoute})
+	_, err = wshclient.AuthenticateCommand(RpcClient, jwtToken, &wshrpc.RpcOpts{Route: wshutil.ControlRoute})
+	if err != nil {
+		return fmt.Errorf("error authenticating: %v", err)
+	}
 	blockId := os.Getenv("WAVETERM_BLOCKID")
 	if blockId != "" {
 		peerInfo := fmt.Sprintf("domain:block:%s", blockId)

pkg/util/sigutil/sigusr1_notwindows.go

@@ -6,6 +6,7 @@
 package sigutil
 
 import (
+	"log"
 	"os"
 	"os/signal"
 	"syscall"
@@ -26,6 +27,7 @@ func InstallSIGUSR1Handler() {
 		for range sigCh {
 			file, err := os.Create(DumpFilePath)
 			if err != nil {
+				log.Printf("error creating dump file %q: %v", DumpFilePath, err)
 				continue
 			}
 			utilfn.DumpGoRoutineStacks(file)