fix a couple local conn checks

Author: sawka

pkg/blockcontroller/blockcontroller.go

@@ -212,7 +212,7 @@ func ResyncController(ctx context.Context, tabId string, blockId string, rtOpts
 		// For shell/cmd, check connection status first
 		if controllerName == BlockController_Shell || controllerName == BlockController_Cmd {
 			connName := blockData.Meta.GetString(waveobj.MetaKey_Connection, "")
-			if connName != "" {
+			if !conncontroller.IsLocalConnName(connName) {
 				err = CheckConnStatus(blockId)
 				if err != nil {
 					return fmt.Errorf("cannot start shellproc: %w", err)
@@ -362,7 +362,7 @@ func CheckConnStatus(blockId string) error {
 		return fmt.Errorf("error getting block: %w", err)
 	}
 	connName := bdata.Meta.GetString(waveobj.MetaKey_Connection, "")
-	if connName == "" {
+	if conncontroller.IsLocalConnName(connName) {
 		return nil
 	}
 	if strings.HasPrefix(connName, "wsl://") {

pkg/blockcontroller/shellcontroller.go

@@ -334,7 +334,7 @@ func (bc *ShellController) getConnUnion(logCtx context.Context, remoteName strin
 		rtn.ConnType = ConnType_Wsl
 		rtn.WslConn = wslConn
 		rtn.WshEnabled = wshEnabled && wslConn.WshEnabled.Load()
-	} else if strings.HasPrefix(remoteName, "local:") || remoteName == "local" || remoteName == "" {
+	} else if conncontroller.IsLocalConnName(remoteName) {
 		rtn.ConnType = ConnType_Local
 		rtn.WshEnabled = wshEnabled
 	} else {

pkg/remote/conncontroller/conncontroller.go

@@ -77,6 +77,10 @@ var ConnServerCmdTemplate = strings.TrimSpace(
 		"exec %s connserver",
 	}, "\n"))
 
+func IsLocalConnName(connName string) bool {
+	return strings.HasPrefix(connName, "local:") || connName == "local" || connName == ""
+}
+
 func GetAllConnStatus() []wshrpc.ConnStatus {
 	globalLock.Lock()
 	defer globalLock.Unlock()
@@ -833,7 +837,7 @@ func GetConn(opts *remote.SSHOpts) *SSHConn {
 
 // Convenience function for ensuring a connection is established
 func EnsureConnection(ctx context.Context, connName string) error {
-	if connName == "" {
+	if IsLocalConnName(connName) {
 		return nil
 	}
 	connOpts, err := remote.ParseOpts(connName)