implement a true atomic SetFn for atoms

Author: sawka

tsunami/app/atom.go

@@ -39,8 +39,9 @@ func (a Atom[T]) Get() T {
 		compWaveId := vc.GetCompWaveId()
 		vc.Root.AtomSetUsedBy(a.name, compWaveId, true)
 	}
-	val := a.client.GetAtomVal(a.name)
-	return util.GetTypedAtomValue[T](val, a.name)
+	val := a.client.Root.GetAtomVal(a.name)
+	typedVal := util.GetTypedAtomValue[T](val, a.name)
+	return typedVal
 }
 
 // Set updates the atom's value
@@ -63,10 +64,11 @@ func (a Atom[T]) SetFn(fn func(T) T) {
 		logInvalidAtomSet(a.name)
 		return
 	}
-	val := a.client.GetAtomVal(a.name)
-	typedVal := util.GetTypedAtomValue[T](val, a.name)
-	newVal := fn(typedVal)
-	if err := a.client.Root.SetAtomVal(a.name, newVal); err != nil {
+	err := a.client.Root.SetFnAtomVal(a.name, func(val any) any {
+		typedVal := util.GetTypedAtomValue[T](val, a.name)
+		return fn(typedVal)
+	})
+	if err != nil {
 		log.Printf("Failed to set atom value for %s: %v", a.name, err)
 		return
 	}

tsunami/demo/.gitignore

@@ -0,0 +1 @@
+test/

tsunami/engine/atomimpl.go

@@ -29,10 +29,7 @@ func (a *AtomImpl[T]) GetVal() any {
 	return a.val
 }
 
-func (a *AtomImpl[T]) SetVal(val any) error {
-	a.lock.Lock()
-	defer a.lock.Unlock()
-
+func (a *AtomImpl[T]) setVal_nolock(val any) error {
 	if val == nil {
 		var zero T
 		a.val = zero
@@ -61,6 +58,20 @@ func (a *AtomImpl[T]) SetVal(val any) error {
 	return nil
 }
 
+func (a *AtomImpl[T]) SetVal(val any) error {
+	a.lock.Lock()
+	defer a.lock.Unlock()
+	return a.setVal_nolock(val)
+}
+
+func (a *AtomImpl[T]) SetFnVal(setFn func(any) any) error {
+	a.lock.Lock()
+	defer a.lock.Unlock()
+	
+	newVal := setFn(a.val)
+	return a.setVal_nolock(newVal)
+}
+
 func (a *AtomImpl[T]) SetUsedBy(waveId string, used bool) {
 	a.lock.Lock()
 	defer a.lock.Unlock()

tsunami/engine/clientimpl.go

@@ -218,10 +218,6 @@ func (c *ClientImpl) SendAsyncInitiation() error {
 	}
 }
 
-func (c *ClientImpl) GetAtomVal(name string) any {
-	return c.Root.GetAtomVal(name)
-}
-
 func makeNullRendered() *rpctypes.RenderedElem {
 	return &rpctypes.RenderedElem{WaveId: uuid.New().String(), Tag: vdom.WaveNullTag}
 }

tsunami/engine/rootelem.go

@@ -25,6 +25,7 @@ type EffectWorkElem struct {
 type genAtom interface {
 	GetVal() any
 	SetVal(any) error
+	SetFnVal(func(any) any) error
 	SetUsedBy(string, bool)
 	GetUsedBy() []string
 }
@@ -157,6 +158,17 @@ func (r *RootElem) SetAtomVal(name string, val any) error {
 	return atom.SetVal(val)
 }
 
+func (r *RootElem) SetFnAtomVal(name string, setFn func(any) any) error {
+	r.atomLock.Lock()
+	defer r.atomLock.Unlock()
+
+	atom, ok := r.Atoms[name]
+	if !ok {
+		return fmt.Errorf("atom %q not found", name)
+	}
+	return atom.SetFnVal(setFn)
+}
+
 func (r *RootElem) RemoveAtom(name string) {
 	r.atomLock.Lock()
 	defer r.atomLock.Unlock()