Skip to content

Commit 3036946

Browse files
committed
minor cleanups
1 parent 12faedb commit 3036946

4 files changed

Lines changed: 5 additions & 6 deletions

File tree

docs/docs/telemetry.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ Below is a list of the event types collected in the new telemetry system. More e
6666
| `app:shutdown` | Logged on every shutdown |
6767
| `app:activity` | Logged once per hour of app activity |
6868
| `app:display` | Logged on startup and contains information about size of displays |
69-
| `app:counts` | Logged once per hour when app is active, contains basic counts like number of windows, tabs, workspaces, blocks, etc. |
69+
| `app:counts` | Logged once per hour when app is active, contains basic counts like number of windows, tabs, workspaces, blocks, number of settings customizations, etc. |
7070
| `action:magnify` | Logged each time a block is magnified |
7171
| `action:settabtheme` | Logged each time a tab theme is changed |
7272
| `action:runaicmd` | Logged each time an AI request is made (no prompt information or text is sent), only sends "ai:backendtype" to know what type of AI backend is being used (OpenAI, Claude, Gemini, etc.) |

pkg/wconfig/settingsconfig.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -766,7 +766,7 @@ func (fc *FullConfigType) CountCustomAIPresets() int {
766766
return count
767767
}
768768

769-
// CountCustomSettings returns the number of settings the user has customized from the defaults.
769+
// CountCustomSettings returns the number of settings in the user's settings file.
770770
// This excludes telemetry:enabled which doesn't count as a customization.
771771
func CountCustomSettings() int {
772772
// Load user settings

pkg/wcore/block.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -99,16 +99,16 @@ func CreateBlockWithTelemetry(ctx context.Context, tabId string, blockDef *waveo
9999
}
100100
}
101101
if recordTelemetry {
102-
go recordBlockCreationTelemetry(blockDef)
102+
blockView := blockDef.Meta.GetString(waveobj.MetaKey_View, "")
103+
go recordBlockCreationTelemetry(blockView)
103104
}
104105
return blockData, nil
105106
}
106107

107-
func recordBlockCreationTelemetry(blockDef *waveobj.BlockDef) {
108+
func recordBlockCreationTelemetry(blockView string) {
108109
defer func() {
109110
panichandler.PanicHandler("CreateBlock:telemetry", recover())
110111
}()
111-
blockView := blockDef.Meta.GetString(waveobj.MetaKey_View, "")
112112
if blockView == "" {
113113
return
114114
}

pkg/wcore/layout.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,6 @@ func QueueLayoutActionForTab(ctx context.Context, tabId string, actions ...waveo
127127
}
128128

129129
func ApplyPortableLayout(ctx context.Context, tabId string, layout PortableLayout, recordTelemetry bool) error {
130-
log.Printf("ApplyPortableLayout, tabId: %s, layout: %v\n", tabId, layout)
131130
actions := make([]waveobj.LayoutActionData, len(layout)+1)
132131
actions[0] = waveobj.LayoutActionData{ActionType: LayoutActionDataType_ClearTree}
133132
for i := 0; i < len(layout); i++ {

0 commit comments

Comments
 (0)