dont depend on full settings atom. showmenubar also should cause a re-layout

Author: sawka

frontend/app/tab/tabbar.tsx

@@ -188,7 +188,7 @@ const TabBar = memo(({ workspace }: TabBarProps) => {
     const activeTabId = useAtomValue(env.atoms.staticTabId);
     const isFullScreen = useAtomValue(env.atoms.isFullScreen);
     const zoomFactor = useAtomValue(env.atoms.zoomFactorAtom);
-    const settings = useAtomValue(env.atoms.settingsAtom);
+    const showMenuBar = useAtomValue(env.getSettingsKeyAtom("window:showmenubar"));
     const confirmClose = useAtomValue(env.getSettingsKeyAtom("tab:confirmclose")) ?? false;
     const hideAiButton = useAtomValue(env.getSettingsKeyAtom("app:hideaibutton"));
     const appUpdateStatus = useAtomValue(env.atoms.updaterStatusAtom);
@@ -341,7 +341,17 @@ const TabBar = memo(({ workspace }: TabBarProps) => {
                 prevAllLoadedRef.current = true;
             }
         }
-    }, [tabIds, tabsLoaded, newTabId, saveTabsPosition, hideAiButton, appUpdateStatus, hasConfigErrors, zoomFactor]);
+    }, [
+        tabIds,
+        tabsLoaded,
+        newTabId,
+        saveTabsPosition,
+        hideAiButton,
+        appUpdateStatus,
+        hasConfigErrors,
+        zoomFactor,
+        showMenuBar,
+    ]);
 
     const getDragDirection = (currentX: number) => {
         let dragDirection: string;
@@ -620,7 +630,7 @@ const TabBar = memo(({ workspace }: TabBarProps) => {
     }
 
     const tabsWrapperWidth = tabIds.length * tabWidthRef.current;
-    const showAppMenuButton = env.isWindows() || (!env.isMacOS() && !settings["window:showmenubar"]);
+    const showAppMenuButton = env.isWindows() || (!env.isMacOS() && !showMenuBar);
 
     // Calculate window drag left width based on platform and state
     let windowDragLeftWidth = 10;

frontend/app/tab/tabbarenv.ts

@@ -20,12 +20,11 @@ export type TabBarEnv = WaveEnvSubset<{
         staticTabId: WaveEnv["atoms"]["staticTabId"];
         isFullScreen: WaveEnv["atoms"]["isFullScreen"];
         zoomFactorAtom: WaveEnv["atoms"]["zoomFactorAtom"];
-        settingsAtom: WaveEnv["atoms"]["settingsAtom"];
         reinitVersion: WaveEnv["atoms"]["reinitVersion"];
         updaterStatusAtom: WaveEnv["atoms"]["updaterStatusAtom"];
     };
     wos: WaveEnv["wos"];
-    getSettingsKeyAtom: SettingsKeyAtomFnType<"app:hideaibutton" | "tab:confirmclose">;
+    getSettingsKeyAtom: SettingsKeyAtomFnType<"app:hideaibutton" | "tab:confirmclose" | "window:showmenubar">;
     mockSetWaveObj: WaveEnv["mockSetWaveObj"];
     isWindows: WaveEnv["isWindows"];
     isMacOS: WaveEnv["isMacOS"];