Add terminal cursor style/blink config with block-level overrides (#2933)

Adds support for configuring terminal cursor style and blink behavior in
terminal blocks, with hierarchical resolution (block metadata →
connection overrides → global settings). New keys are `term:cursor`
(`block`/`underline`/`bar`, default `block`) and `term:cursorblink`
(`bool`, default `false`).

- **Config surface: new terminal keys**
  - Added to global settings schema/types:
    - `pkg/wconfig/settingsconfig.go`
  - Added to block metadata typing:
    - `pkg/waveobj/wtypemeta.go`
  - Added default values:
    - `pkg/wconfig/defaultconfig/settings.json`
      - `"term:cursor": "block"`
      - `"term:cursorblink": false`

- **Frontend terminal behavior (xterm options)**
  - `frontend/app/view/term/termwrap.ts`
- Added `setCursorStyle()` with value normalization (`underline`/`bar`
else fallback `block`)
    - Added `setCursorBlink()`
- Applies both options on terminal construction via
`getOverrideConfigAtom(...)`
  - `frontend/app/view/term/term-model.ts`
    - Subscribes to `term:cursor` and `term:cursorblink` override atoms
- Propagates live updates to `term.options.cursorStyle` /
`term.options.cursorBlink`
    - Cleans up subscriptions in `dispose()`

- **Generated artifacts**
  - Regenerated config/type outputs after Go type additions:
    - `schema/settings.json`
    - `pkg/wconfig/metaconsts.go`
    - `pkg/waveobj/metaconsts.go`
    - `frontend/types/gotypes.d.ts`

- **Docs**
  - Updated config reference and default config example:
    - `docs/docs/config.mdx`

```ts
// termwrap.ts
this.setCursorStyle(globalStore.get(getOverrideConfigAtom(this.blockId, "term:cursor")));
this.setCursorBlink(globalStore.get(getOverrideConfigAtom(this.blockId, "term:cursorblink")) ?? false);

// term-model.ts (live updates)
const termCursorAtom = getOverrideConfigAtom(blockId, "term:cursor");
this.termCursorUnsubFn = globalStore.sub(termCursorAtom, () => {
    this.termRef.current?.setCursorStyle(globalStore.get(termCursorAtom));
});
```

<!-- START COPILOT CODING AGENT TIPS -->
---

🔒 GitHub Advanced Security automatically protects Copilot coding agent
pull requests. You can protect all pull requests by enabling Advanced
Security for your repositories. [Learn more about Advanced
Security.](https://gh.io/cca-advanced-security)

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: sawka <2722291+sawka@users.noreply.github.com>
Co-authored-by: sawka <mike@commandline.dev>

Author: Copilot

.github/workflows/copilot-setup-steps.yml

@@ -7,9 +7,9 @@ on:
     pull_request:
         paths: [.github/workflows/copilot-setup-steps.yml]
 
-env:
-    GO_VERSION: "1.25.6"
-    NODE_VERSION: 22
+# Note: global env vars are NOT used here — they are not reliable in all
+# GitHub Actions contexts (e.g. Copilot setup steps). Values are inlined
+# directly into each step that needs them.
 
 jobs:
     copilot-setup-steps:
@@ -23,12 +23,12 @@ jobs:
             # Go + Node versions match your helper
             - uses: actions/setup-go@v6
               with:
-                  go-version: ${{ env.GO_VERSION }}
+                  go-version: "1.25.6"
                   cache-dependency-path: go.sum
 
             - uses: actions/setup-node@v6
               with:
-                  node-version: ${{ env.NODE_VERSION }}
+                  node-version: 22
                   cache: npm
                   cache-dependency-path: package-lock.json
 

docs/docs/config.mdx

@@ -69,6 +69,8 @@ wsh editconfig
 | term:allowbracketedpaste             | bool     | allow bracketed paste mode in terminal (default false)                                                                                                                                                                                                        |
 | term:shiftenternewline               | bool     | when enabled, Shift+Enter sends escape sequence + newline (\u001b\n) instead of carriage return, useful for claude code and similar AI coding tools (default false)                                                                                         |
 | term:macoptionismeta                 | bool     | on macOS, treat the Option key as Meta key for terminal keybindings (default false)                                                                                                                                                                          |
+| term:cursor <VersionBadge version="v0.14" />                        | string   | terminal cursor style. valid values are `block` (default), `underline`, and `bar`                                                                                                                                                                            |
+| term:cursorblink <VersionBadge version="v0.14" />                   | bool     | when enabled, terminal cursor blinks (default false)                                                                                                                                                                                                          |
 | term:bellsound <VersionBadge version="v0.14" />                      | bool     | when enabled, plays the system beep sound when the terminal bell (BEL character) is received (default false)                                                                                                                                                  |
 | term:bellindicator <VersionBadge version="v0.14" />                  | bool     | when enabled, shows a visual indicator in the tab when the terminal bell is received (default false)                                                                                                                                                           |
 | term:durable <VersionBadge version="v0.14" />                        | bool     | makes remote terminal sessions durable across network disconnects (defaults to false)                                                                                                                                                                           |
@@ -145,6 +147,8 @@ For reference, this is the current default configuration (v0.14.0):
     "telemetry:enabled": true,
     "term:bellsound": false,
     "term:bellindicator": false,
+    "term:cursor": "block",
+    "term:cursorblink": false,
     "term:copyonselect": true,
     "term:durable": false,
     "waveai:showcloudmodes": true,

eslint.config.js

@@ -73,7 +73,13 @@ export default [
 
     {
         rules: {
-            "@typescript-eslint/no-unused-vars": "warn",
+            "@typescript-eslint/no-unused-vars": [
+                "warn",
+                {
+                    argsIgnorePattern: "^_$",
+                    varsIgnorePattern: "^_$",
+                },
+            ],
             "prefer-const": "warn",
             "no-empty": "warn",
         },

frontend/app/view/term/term-model.ts

@@ -77,6 +77,8 @@ export class TermViewModel implements ViewModel {
     blockJobStatusVersionTs: number;
     blockJobStatusUnsubFn: () => void;
     termBPMUnsubFn: () => void;
+    termCursorUnsubFn: () => void;
+    termCursorBlinkUnsubFn: () => void;
     isCmdController: jotai.Atom<boolean>;
     isRestarting: jotai.PrimitiveAtom<boolean>;
     termDurableStatus: jotai.Atom<BlockJobStatusData | null>;
@@ -376,6 +378,18 @@ export class TermViewModel implements ViewModel {
                 this.termRef.current.terminal.options.ignoreBracketedPasteMode = !allowBPM;
             }
         });
+        const termCursorAtom = getOverrideConfigAtom(blockId, "term:cursor");
+        this.termCursorUnsubFn = globalStore.sub(termCursorAtom, () => {
+            if (this.termRef.current?.terminal) {
+                this.termRef.current.setCursorStyle(globalStore.get(termCursorAtom));
+            }
+        });
+        const termCursorBlinkAtom = getOverrideConfigAtom(blockId, "term:cursorblink");
+        this.termCursorBlinkUnsubFn = globalStore.sub(termCursorBlinkAtom, () => {
+            if (this.termRef.current?.terminal) {
+                this.termRef.current.setCursorBlink(globalStore.get(termCursorBlinkAtom) ?? false);
+            }
+        });
     }
 
     getShellIntegrationIconButton(get: jotai.Getter): IconButtonDecl | null {
@@ -521,6 +535,8 @@ export class TermViewModel implements ViewModel {
         this.shellProcStatusUnsubFn?.();
         this.blockJobStatusUnsubFn?.();
         this.termBPMUnsubFn?.();
+        this.termCursorUnsubFn?.();
+        this.termCursorBlinkUnsubFn?.();
     }
 
     giveFocus(): boolean {
@@ -1017,6 +1033,91 @@ export class TermViewModel implements ViewModel {
                 });
             },
         });
+        const overrideCursor = blockData?.meta?.["term:cursor"] as string | null | undefined;
+        const overrideCursorBlink = blockData?.meta?.["term:cursorblink"] as boolean | null | undefined;
+        const isCursorDefault = overrideCursor == null && overrideCursorBlink == null;
+        // normalize for comparison: null/undefined/"block" all mean "block"
+        const effectiveCursor = overrideCursor === "underline" || overrideCursor === "bar" ? overrideCursor : "block";
+        const effectiveCursorBlink = overrideCursorBlink === true;
+        const cursorSubMenu: ContextMenuItem[] = [
+            {
+                label: "Default",
+                type: "checkbox",
+                checked: isCursorDefault,
+                click: () => {
+                    RpcApi.SetMetaCommand(TabRpcClient, {
+                        oref: WOS.makeORef("block", this.blockId),
+                        meta: { "term:cursor": null, "term:cursorblink": null },
+                    });
+                },
+            },
+            {
+                label: "Block",
+                type: "checkbox",
+                checked: !isCursorDefault && effectiveCursor === "block" && !effectiveCursorBlink,
+                click: () => {
+                    RpcApi.SetMetaCommand(TabRpcClient, {
+                        oref: WOS.makeORef("block", this.blockId),
+                        meta: { "term:cursor": "block", "term:cursorblink": false },
+                    });
+                },
+            },
+            {
+                label: "Block (Blinking)",
+                type: "checkbox",
+                checked: !isCursorDefault && effectiveCursor === "block" && effectiveCursorBlink,
+                click: () => {
+                    RpcApi.SetMetaCommand(TabRpcClient, {
+                        oref: WOS.makeORef("block", this.blockId),
+                        meta: { "term:cursor": "block", "term:cursorblink": true },
+                    });
+                },
+            },
+            {
+                label: "Bar",
+                type: "checkbox",
+                checked: !isCursorDefault && effectiveCursor === "bar" && !effectiveCursorBlink,
+                click: () => {
+                    RpcApi.SetMetaCommand(TabRpcClient, {
+                        oref: WOS.makeORef("block", this.blockId),
+                        meta: { "term:cursor": "bar", "term:cursorblink": false },
+                    });
+                },
+            },
+            {
+                label: "Bar (Blinking)",
+                type: "checkbox",
+                checked: !isCursorDefault && effectiveCursor === "bar" && effectiveCursorBlink,
+                click: () => {
+                    RpcApi.SetMetaCommand(TabRpcClient, {
+                        oref: WOS.makeORef("block", this.blockId),
+                        meta: { "term:cursor": "bar", "term:cursorblink": true },
+                    });
+                },
+            },
+            {
+                label: "Underline",
+                type: "checkbox",
+                checked: !isCursorDefault && effectiveCursor === "underline" && !effectiveCursorBlink,
+                click: () => {
+                    RpcApi.SetMetaCommand(TabRpcClient, {
+                        oref: WOS.makeORef("block", this.blockId),
+                        meta: { "term:cursor": "underline", "term:cursorblink": false },
+                    });
+                },
+            },
+            {
+                label: "Underline (Blinking)",
+                type: "checkbox",
+                checked: !isCursorDefault && effectiveCursor === "underline" && effectiveCursorBlink,
+                click: () => {
+                    RpcApi.SetMetaCommand(TabRpcClient, {
+                        oref: WOS.makeORef("block", this.blockId),
+                        meta: { "term:cursor": "underline", "term:cursorblink": true },
+                    });
+                },
+            },
+        ];
         fullMenu.push({
             label: "Themes",
             submenu: submenu,
@@ -1025,6 +1126,10 @@ export class TermViewModel implements ViewModel {
             label: "Font Size",
             submenu: fontSizeSubMenu,
         });
+        fullMenu.push({
+            label: "Cursor",
+            submenu: cursorSubMenu,
+        });
         fullMenu.push({
             label: "Transparency",
             submenu: transparencySubMenu,

frontend/app/view/term/term.tsx

@@ -20,7 +20,7 @@ import * as jotai from "jotai";
 import * as React from "react";
 import { TermStickers } from "./termsticker";
 import { TermThemeUpdater } from "./termtheme";
-import { computeTheme } from "./termutil";
+import { computeTheme, normalizeCursorStyle } from "./termutil";
 import { TermWrap } from "./termwrap";
 import "./xterm.css";
 
@@ -275,6 +275,8 @@ const TerminalView = ({ blockId, model }: ViewComponentProps<TermViewModel>) =>
         }
         const termAllowBPM = globalStore.get(model.termBPMAtom) ?? true;
         const termMacOptionIsMeta = globalStore.get(termMacOptionIsMetaAtom) ?? false;
+        const termCursorStyle = normalizeCursorStyle(globalStore.get(getOverrideConfigAtom(blockId, "term:cursor")));
+        const termCursorBlink = globalStore.get(getOverrideConfigAtom(blockId, "term:cursorblink")) ?? false;
         const wasFocused = model.termRef.current != null && globalStore.get(model.nodeModel.isFocused);
         const termWrap = new TermWrap(
             tabModel.tabId,
@@ -292,6 +294,8 @@ const TerminalView = ({ blockId, model }: ViewComponentProps<TermViewModel>) =>
                 allowProposedApi: true, // Required by @xterm/addon-search to enable search functionality and decorations
                 ignoreBracketedPasteMode: !termAllowBPM,
                 macOptionIsMeta: termMacOptionIsMeta,
+                cursorStyle: termCursorStyle,
+                cursorBlink: termCursorBlink,
             },
             {
                 keydownHandler: model.handleTerminalKeydown.bind(model),

frontend/app/view/term/termutil.ts

@@ -10,6 +10,13 @@ import { colord } from "colord";
 
 export type GenClipboardItem = { text?: string; image?: Blob };
 
+export function normalizeCursorStyle(cursorStyle: string): TermTypes.Terminal["options"]["cursorStyle"] {
+    if (cursorStyle === "underline" || cursorStyle === "bar") {
+        return cursorStyle;
+    }
+    return "block";
+}
+
 function applyTransparencyToColor(hexColor: string, transparency: number): string {
     const alpha = 1 - transparency; // transparency is already 0-1
     return colord(hexColor).alpha(alpha).toHex();
@@ -34,7 +41,7 @@ export function computeTheme(
             themeCopy.selectionBackground = applyTransparencyToColor(themeCopy.selectionBackground, termTransparency);
         }
     }
-    let bgcolor = themeCopy.background;
+    const bgcolor = themeCopy.background;
     themeCopy.background = "#00000000";
     return [themeCopy, bgcolor];
 }

frontend/app/view/term/termwrap.ts

@@ -34,7 +34,7 @@ import {
     handleOsc7Command,
     type ShellIntegrationStatus,
 } from "./osc-handlers";
-import { bufferLinesToText, createTempFileFromBlob, extractAllClipboardData } from "./termutil";
+import { bufferLinesToText, createTempFileFromBlob, extractAllClipboardData, normalizeCursorStyle } from "./termutil";
 
 const dlog = debug("wave:termwrap");
 
@@ -211,6 +211,14 @@ export class TermWrap {
         return this.blockId;
     }
 
+    setCursorStyle(cursorStyle: string) {
+        this.terminal.options.cursorStyle = normalizeCursorStyle(cursorStyle);
+    }
+
+    setCursorBlink(cursorBlink: boolean) {
+        this.terminal.options.cursorBlink = cursorBlink ?? false;
+    }
+
     resetCompositionState() {
         this.isComposing = false;
         this.composingData = "";

frontend/types/gotypes.d.ts

@@ -1094,6 +1094,8 @@ declare global {
         "term:allowbracketedpaste"?: boolean;
         "term:shiftenternewline"?: boolean;
         "term:macoptionismeta"?: boolean;
+        "term:cursor"?: string;
+        "term:cursorblink"?: boolean;
         "term:conndebug"?: string;
         "term:bellsound"?: boolean;
         "term:bellindicator"?: boolean;
@@ -1287,6 +1289,8 @@ declare global {
         "term:allowbracketedpaste"?: boolean;
         "term:shiftenternewline"?: boolean;
         "term:macoptionismeta"?: boolean;
+        "term:cursor"?: string;
+        "term:cursorblink"?: boolean;
         "term:bellsound"?: boolean;
         "term:bellindicator"?: boolean;
         "term:durable"?: boolean;

pkg/waveobj/metaconsts.go

@@ -116,6 +116,8 @@ const (
 	MetaKey_TermAllowBracketedPaste          = "term:allowbracketedpaste"
 	MetaKey_TermShiftEnterNewline            = "term:shiftenternewline"
 	MetaKey_TermMacOptionIsMeta              = "term:macoptionismeta"
+	MetaKey_TermCursor                       = "term:cursor"
+	MetaKey_TermCursorBlink                  = "term:cursorblink"
 	MetaKey_TermConnDebug                    = "term:conndebug"
 	MetaKey_TermBellSound                    = "term:bellsound"
 	MetaKey_TermBellIndicator                = "term:bellindicator"

pkg/waveobj/wtypemeta.go

@@ -120,6 +120,8 @@ type MetaTSType struct {
 	TermAllowBracketedPaste *bool    `json:"term:allowbracketedpaste,omitempty"`
 	TermShiftEnterNewline   *bool    `json:"term:shiftenternewline,omitempty"`
 	TermMacOptionIsMeta     *bool    `json:"term:macoptionismeta,omitempty"`
+	TermCursor              string   `json:"term:cursor,omitempty"`
+	TermCursorBlink         *bool    `json:"term:cursorblink,omitempty"`
 	TermConnDebug           string   `json:"term:conndebug,omitempty"` // null, info, debug
 	TermBellSound           *bool    `json:"term:bellsound,omitempty"`
 	TermBellIndicator       *bool    `json:"term:bellindicator,omitempty"`