Do not allow large/recursive file transfers (for now), remove s3 and wavefile fs implementations (#2808)

Big simplification. Remove the FileShare interface that abstracted
wsh://, s3://, and wavefile:// files.
It produced a lot of complexity for very little usage. We're just going
to focus on the wsh:// implementation since that's core to our remote
workflows.

* remove s3 implementation (and connections, and picker items for
preview)
* remove capabilities for FE
* remove wavefile backend impl as well
* simplify wsh file remote backend
* remove ability to copy/move/ls recursively
* limit file transfers to 32m

the longer term fix here is to use the new streaming RPC primitives.
they have full end-to-end flow-control built in and will not create
pipeline stalls, blocking other requests, and OOM issues.

these other impls had to be removed (or fixed) because transferring
large files could cause stalls or crashes with the new router
infrastructure.

Author: sawka

cmd/generatego/main-generatego.go

@@ -31,7 +31,6 @@ func GenerateWshClient() error {
 		"github.com/wavetermdev/waveterm/pkg/waveobj",
 		"github.com/wavetermdev/waveterm/pkg/wps",
 		"github.com/wavetermdev/waveterm/pkg/vdom",
-		"github.com/wavetermdev/waveterm/pkg/util/iochan/iochantypes",
 		"github.com/wavetermdev/waveterm/pkg/aiusechat/uctypes",
 	})
 	wshDeclMap := wshrpc.GenerateWshCommandDeclMap()

cmd/wsh/cmd/wshcmd-file-util.go

@@ -14,7 +14,6 @@ import (
 	"github.com/wavetermdev/waveterm/pkg/remote/connparse"
 	"github.com/wavetermdev/waveterm/pkg/remote/fileshare/fsutil"
 	"github.com/wavetermdev/waveterm/pkg/util/fileutil"
-	"github.com/wavetermdev/waveterm/pkg/util/wavefileutil"
 	"github.com/wavetermdev/waveterm/pkg/wshrpc"
 	"github.com/wavetermdev/waveterm/pkg/wshrpc/wshclient"
 )
@@ -96,90 +95,6 @@ func streamReadFromFile(ctx context.Context, fileData wshrpc.FileData, writer io
 	return fsutil.ReadFileStreamToWriter(ctx, ch, writer)
 }
 
-type fileListResult struct {
-	info *wshrpc.FileInfo
-	err  error
-}
-
-func streamFileList(zoneId string, path string, recursive bool, filesOnly bool) (<-chan fileListResult, error) {
-	resultChan := make(chan fileListResult)
-
-	// If path doesn't end in /, do a single file lookup
-	if path != "" && !strings.HasSuffix(path, "/") {
-		go func() {
-			defer close(resultChan)
-
-			fileData := wshrpc.FileData{
-				Info: &wshrpc.FileInfo{
-					Path: fmt.Sprintf(wavefileutil.WaveFilePathPattern, zoneId, path)},
-			}
-
-			info, err := wshclient.FileInfoCommand(RpcClient, fileData, &wshrpc.RpcOpts{Timeout: 2000})
-			err = convertNotFoundErr(err)
-			if err == fs.ErrNotExist {
-				resultChan <- fileListResult{err: fmt.Errorf("%s: No such file or directory", path)}
-				return
-			}
-			if err != nil {
-				resultChan <- fileListResult{err: err}
-				return
-			}
-			resultChan <- fileListResult{info: info}
-		}()
-		return resultChan, nil
-	}
-
-	// Directory listing case
-	go func() {
-		defer close(resultChan)
-
-		prefix := path
-		prefixLen := len(prefix)
-		offset := 0
-		foundAny := false
-
-		for {
-			listData := wshrpc.FileListData{
-				Path: fmt.Sprintf(wavefileutil.WaveFilePathPattern, zoneId, prefix),
-				Opts: &wshrpc.FileListOpts{
-					All:    recursive,
-					Offset: offset,
-					Limit:  100}}
-
-			files, err := wshclient.FileListCommand(RpcClient, listData, &wshrpc.RpcOpts{Timeout: 2000})
-			if err != nil {
-				resultChan <- fileListResult{err: err}
-				return
-			}
-
-			if len(files) == 0 {
-				if !foundAny && prefix != "" {
-					resultChan <- fileListResult{err: fmt.Errorf("%s: No such file or directory", path)}
-				}
-				return
-			}
-
-			for _, f := range files {
-				if filesOnly && f.IsDir {
-					continue
-				}
-				foundAny = true
-				if prefixLen > 0 {
-					f.Name = f.Name[prefixLen:]
-				}
-				resultChan <- fileListResult{info: f}
-			}
-
-			if len(files) < 100 {
-				return
-			}
-			offset += len(files)
-		}
-	}()
-
-	return resultChan, nil
-}
-
 func fixRelativePaths(path string) (string, error) {
 	conn, err := connparse.ParseURI(path)
 	if err != nil {