Commit bb8dffc
fix: address code review feedback for keybindings feature
- Fix hasJsonView to omit (array format, not key-value) and add docsUrl
- Add runtime validation in buildKeyMaps for malformed override entries
- Fix mock default config to use "[]" instead of empty string
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>1 parent d47fd03 commit bb8dffc
File tree
3 files changed
+10
-2
lines changed- frontend
- app
- store
- view/waveconfig
- preview/mock
3 files changed
+10
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
840 | 840 | | |
841 | 841 | | |
842 | 842 | | |
| 843 | + | |
| 844 | + | |
| 845 | + | |
| 846 | + | |
| 847 | + | |
| 848 | + | |
| 849 | + | |
| 850 | + | |
843 | 851 | | |
844 | 852 | | |
845 | 853 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
69 | 69 | | |
70 | 70 | | |
71 | 71 | | |
72 | | - | |
| 72 | + | |
73 | 73 | | |
74 | 74 | | |
75 | 75 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
23 | | - | |
| 23 | + | |
24 | 24 | | |
25 | 25 | | |
0 commit comments