Commit f4b032a
fix(webview): gate real popups on window features, not disposition alone
Electron's setWindowOpenHandler reports disposition "new-window" not only for
scripted window.open(...) popups but also for shift+clicked links. Keying the
allow case on disposition alone meant a shift-clicked link in a web block opened
an unmanaged BrowserWindow instead of a Wave web block. OAuth/SSO popups always
pass a window-features string (width/height); plain links carry none, so also
require a non-empty details.features to allow a real popup.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>1 parent 50f295f commit f4b032a
1 file changed
Lines changed: 3 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
325 | 325 | | |
326 | 326 | | |
327 | 327 | | |
328 | | - | |
| 328 | + | |
| 329 | + | |
| 330 | + | |
329 | 331 | | |
330 | 332 | | |
331 | 333 | | |
| |||
0 commit comments