Backport: fix stale remote URL for Python 3.8 (v0.16.2)#300
Merged
hasaant merged 2 commits intoApr 6, 2026
Merged
Conversation
…16.2) Cherry-pick of 1b93722 onto the v0.16.x branch for Python 3.8 compatibility. The acceleration service cannot use pygitops 0.17.0+ (requires Python 3.10+), so this backports the URL sync fix to a release that supports Python >=3.7. Fixes SRVLC-2064 Made-with: Cursor
jashparekh
approved these changes
Apr 6, 2026
Resolve conflicts: - setup.cfg: accept deletion (project uses pyproject.toml on main) - tests/test_operations.py: drop duplicate tests already present from wayfair-incubator#298 Made-with: Cursor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #300 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 7 +1
Lines 173 176 +3
Branches 20 16 -4
=========================================
+ Hits 173 176 +3 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport of #298 for consumers still on Python 3.8 (e.g. dev-plats-acceleration-service).
pygitops 0.17.0+ requires Python 3.10+, so v0.18.0 can't be installed by services still running 3.8. This cherry-picks the same URL sync fix onto the v0.16.x line and bumps the version to 0.16.2.
The fix is identical: if the cached origin URL doesn't match the caller-provided repo_url, call set_url() before fetching.
Changes
Test plan
PH: SRVLC-2064