dynamic_modules: use addStreamFilter for dynamic_modules http filter callback (envoyproxy#38583)

Using addStreamDecoderFilter and
addStreamEncoderFilter will cause filter to be added twice in filter
manager, so that callback like onStreamComplete will be called twice for
one filter. Using addStreamFilter can make sure that callback will only
be called once for one filter.


Signed-off-by: Zhaoyang Li <zhaoyli311@gmail.com>

Author: zhaoyangli311

source/extensions/filters/http/dynamic_modules/factory.cc

@@ -42,8 +42,7 @@ absl::StatusOr<Http::FilterFactoryCb> DynamicModuleConfigFactory::createFilterFa
         std::make_shared<Envoy::Extensions::DynamicModules::HttpFilters::DynamicModuleHttpFilter>(
             config);
     filter->initializeInModuleFilter();
-    callbacks.addStreamDecoderFilter(filter);
-    callbacks.addStreamEncoderFilter(filter);
+    callbacks.addStreamFilter(filter);
   };
 }
 

test/extensions/dynamic_modules/http/factory_test.cc

@@ -44,8 +44,7 @@ filter_name: foo
   auto factory_cb = result.value();
   Http::MockFilterChainFactoryCallbacks callbacks;
 
-  EXPECT_CALL(callbacks, addStreamDecoderFilter(testing::_));
-  EXPECT_CALL(callbacks, addStreamEncoderFilter(testing::_));
+  EXPECT_CALL(callbacks, addStreamFilter(testing::_));
   factory_cb(callbacks);
 }
 
@@ -74,8 +73,7 @@ filter_name: foo
   auto factory_cb = result.value();
   Http::MockFilterChainFactoryCallbacks callbacks;
 
-  EXPECT_CALL(callbacks, addStreamDecoderFilter(testing::_));
-  EXPECT_CALL(callbacks, addStreamEncoderFilter(testing::_));
+  EXPECT_CALL(callbacks, addStreamFilter(testing::_));
   factory_cb(callbacks);
 }
 
@@ -107,8 +105,7 @@ filter_name: foo
   auto factory_cb = result.value();
   Http::MockFilterChainFactoryCallbacks callbacks;
 
-  EXPECT_CALL(callbacks, addStreamDecoderFilter(testing::_));
-  EXPECT_CALL(callbacks, addStreamEncoderFilter(testing::_));
+  EXPECT_CALL(callbacks, addStreamFilter(testing::_));
   factory_cb(callbacks);
 }