apply suggestion from review

Author: dati18

app/Http/Resources/PublicWikiResource.php

@@ -16,14 +16,11 @@ public function toArray($request): array {
             'sitename' => $this->sitename,
             'wiki_site_stats' => $this->wikiSiteStats,
             'logo_url' => $logoSetting ? $logoSetting->value : null,
-
-            // Checking relation load state before reading it to avoid N+1 query
-            // This relies on the controller to eager load `wikiLatestProfile` relationship
             'reuse_prototype' => $this->wikiLatestProfile
                 ? $this->wikiLatestProfile->purpose === 'data_hub'
                   && $this->wikiLatestProfile->temporality === 'permanent'
                   && $this->wikiLatestProfile->audience === 'wide'
-                : null,
+                : false,
         ];
     }
 }

app/Providers/AppServiceProvider.php

@@ -26,16 +26,5 @@ public function boot(): void {
             $wrappedException = new \Exception("Executing Job '$name' failed.", 1, $event->exception);
             report($wrappedException);
         });
-
-        // Local-only SQL query logging for debugging
-        if ($this->app->environment('local')) {
-            \Event::listen(QueryExecuted::class, function (QueryExecuted $query) {
-                \Log::debug('Query Executed: ', [
-                    'sql' => $query->sql,
-                    'bindings' => $query->bindings,
-                    'connection' => $query->connectionName,
-                ]);
-            });
-        }
     }
 }

routes/api.php

@@ -57,6 +57,6 @@
     });
 
     $router->apiResource('wiki', 'PublicWikiController')->only(['index', 'show']);
-    $router->apiResource('reusePrototype', 'PublicWikiController')->only(['index', 'show']);
+    $router->apiResource('reusePrototype', 'PublicWikiController')->only(['index']);
     $router->apiResource('wikiConversionData', 'ConversionMetricController')->only(['index']);
 });

tests/Http/Controllers/PublicWikiControllerTest.php

@@ -50,17 +50,17 @@ public function testIndexEagerLoadsWikiLatestProfileOnceForCollection(): void {
             ]);
         }
 
-        $profileQueryCount = 0;
-        DB::listen(function (QueryExecuted $query) use (&$profileQueryCount): void {
+        $wikiProfileQueryCount = 0;
+        DB::listen(function (QueryExecuted $query) use (&$wikiProfileQueryCount): void {
             if (str_contains($query->sql, 'wiki_profiles')) {
-                $profileQueryCount++;
+                $wikiProfileQueryCount++;
             }
         });
 
         $controller = new PublicWikiController;
         $resourceCollection = $controller->index(new Request);
 
-        $this->assertSame(1, $profileQueryCount);
+        $this->assertSame(1, $wikiProfileQueryCount);
         $this->assertTrue($resourceCollection->first()->relationLoaded('wikiLatestProfile'));
     }
 }