Add test for fractional day diffs in conversion metrics

Author: dati18

tests/Routes/Wiki/ConversionMetricTest.php

@@ -58,10 +58,10 @@ private function createTestWiki($name, $createdWeeksAgo, $firstEditedWeeksAgo, $
         $wiki->created_at = $current_date->subWeeks($createdWeeksAgo);
         $events = $wiki->wikiLifecycleEvents();
         $update = [];
-        if ($lastEditedWeeksAgo) {
+        if ($lastEditedWeeksAgo !== null) {
             $update['last_edited'] = $current_date->subWeeks($lastEditedWeeksAgo);
         }
-        if ($firstEditedWeeksAgo) {
+        if ($firstEditedWeeksAgo !== null) {
             $update['first_edited'] = $current_date->subWeeks($firstEditedWeeksAgo);
         }
         $events->updateOrCreate($update);
@@ -118,7 +118,7 @@ public function testDownloadJson() {
         );
         $response->assertJsonFragment(
             [
-                'domain' => 'unused.for.a.year.but.now.active.wikibase.cloud',
+                'domain' => 'acvtively.used.for.the.last.year.wikibase.cloud',
                 'time_to_engage_days' => 0,
                 'time_before_wiki_abandoned_days' => null,
                 'number_of_active_editors' => 5,
@@ -134,9 +134,42 @@ public function testDownloadJson() {
         );
     }
 
+    public function testDownloadJsonTruncatesFractionalDayDiffs() {
+        $currentDate = CarbonImmutable::now();
+        $createdAt = $currentDate->subDays(200)->subHours(12); //200.5 days ago
+        $firstEditedAt = $createdAt->addDays(1)->addHours(12); //1.5 days after
+        $lastEditedAt = $currentDate->subDays(100); //100 days ago
+
+        $wiki = Wiki::factory()->create([
+            'domain' => 'fractional.days.cloud',
+            'sitename' => 'Fractional Days Site',
+        ]);
+        WikiSiteStats::factory()->create([
+            'wiki_id' => $wiki->id,
+            'pages' => 77,
+            'activeusers' => 2,
+        ]);
+        $wiki->created_at = $createdAt;
+        $wiki->wikiLifecycleEvents()->updateOrCreate([
+            'first_edited' => $firstEditedAt,
+            'last_edited' => $lastEditedAt,
+        ]);
+        $wiki->save();
+
+        $response = $this->getJson($this->route);
+
+        $response->assertStatus(200);
+        $response->assertJsonFragment([
+            'domain' => 'fractional.days.cloud',
+            'time_to_engage_days' => 1,
+            'time_before_wiki_abandoned_days' => 100,
+            'number_of_active_editors' => 2,
+        ]);
+    }
+
     public function testFunctionalWithMissingLifecycleEventsandStats() {
         $wiki = Wiki::factory()->create([
-            'domain' => 'very.new.wikibase.cloud', 'sitename' => 'bsite',
+            'domain' => 'very.new.cloud', 'sitename' => 'Very New Site',
         ]);
 
         $response = $this->get($this->route);