File tree Expand file tree Collapse file tree
Expand file tree Collapse file tree Original file line number Diff line number Diff line change @@ -40,6 +40,4 @@ public function saveMetrics(Wiki $wiki): void
4040
4141 \Log::info ("New metric recorded for WikiMetrics ID {$ wiki ->id }" );
4242 }
43-
4443}
45-
Original file line number Diff line number Diff line change @@ -26,18 +26,19 @@ class WikiDailyMetrics extends Model
2626 ];
2727
2828 // list of properties which are actual wiki metrics
29- static public $ metricNames = [
29+ public static $ metricNames = [
3030 'pages ' ,
3131 'is_deleted ' ,
3232 ];
3333
34- public function areMetricsEqual (WikiDailyMetrics $ wikiDailyMetrics ) {
35-
34+ public function areMetricsEqual (WikiDailyMetrics $ wikiDailyMetrics ): bool
35+ {
3636 foreach (self ::$ metricNames as $ field ) {
37- if ($ this ->$ field !== $ wikiDailyMetrics ->$ field ) {
37+ if ($ this ->$ field != $ wikiDailyMetrics ->$ field ) {
3838 return false ;
3939 }
4040 }
41+
4142 return true ;
4243 }
4344}
You can’t perform that action at this time.
0 commit comments