Allow and require audience in profile if data-hub (#906)

* only allow audience in profile if data-hub

* fix and improve tests

Author: tarrow

app/Helper/ProfileValidator.php

@@ -11,7 +11,7 @@ public function validate( $profile ): \Illuminate\Validation\Validator {
         return Validator::make($profile, [
             'purpose' => 'in:data_hub,data_lab,tool_lab,test_drive,decide_later,other',
             'purpose_other' => 'string|required_if:purpose,other|missing_unless:purpose,other',
-            'audience' => 'in:narrow,wide,other',
+            'audience' => 'in:narrow,wide,other|required_if:purpose,data_hub|missing_unless:purpose,data_hub',
             'audience_other' => 'string|required_if:audience,other|missing_unless:audience,other',
             'temporality' => 'in:permanent,temporary,decide_later,other',
             'temporality_other' => 'string|required_if:temporality,other|missing_unless:temporality,other',

tests/Helper/ProfileValidatorTest.php

@@ -32,8 +32,7 @@ private function validProfileProvider() {
                 'temporality' => 'permanent',
             ] ],
             [ 'with other values' => [
-                'purpose' => 'other',
-                'purpose_other' => 'for fun',
+                'purpose' => 'data_hub',
                 'audience' => 'other',
                 'audience_other' => 'my cat',
                 'temporality' => 'other',
@@ -46,7 +45,12 @@ private function validProfileProvider() {
     private function invalidProfileProvider() {
         return [
             [ 'missing other keys' => [
-                'purpose' => 'other',
+                'purpose' => 'data_hub',
+                'audience' => 'narrow',
+                'temporality' => 'other',
+            ] ],
+            [ 'audience key present when purpose not data_hub' => [
+                'purpose' => 'data_lab',
                 'audience' => 'narrow',
                 'temporality' => 'permanent',
             ] ],