run rector

Author: deer-wmde

app/Console/Commands/Invitation/Create.php

@@ -17,7 +17,7 @@ class Create extends Command {
      */
     public function handle() {
         $code = trim($this->argument('code'));
-        $jobResult = (new InvitationCreateJob($code))->handle();
+        $jobResult = new InvitationCreateJob($code)->handle();
 
         if ($jobResult) {
             $this->line('Successfully created invitation: ' . $code);

app/Console/Commands/Invitation/CreateBulk.php

@@ -22,7 +22,7 @@ public function handle() {
 
         for ($i = 0; $i < $numCodes; $i++) {
             $code = $helper->generate();
-            $jobResult = (new InvitationCreateJob($code))->handle();
+            $jobResult = new InvitationCreateJob($code)->handle();
 
             if ($jobResult) {
                 $this->line('Successfully created invitation: ' . $code);

app/Console/Commands/Invitation/Delete.php

@@ -17,7 +17,7 @@ class Delete extends Command {
      */
     public function handle() {
         $code = trim($this->argument('code'));
-        (new InvitationDeleteJob($code))->handle();
+        new InvitationDeleteJob($code)->handle();
 
         return 0;
     }

app/Console/Commands/RebuildQueryserviceData.php

@@ -93,7 +93,7 @@ private function getEntitiesForWiki(Wiki $wiki): array {
             : [];
 
         $merged = array_merge($items, $properties, $lexemes);
-        $this->stripPrefixes($merged);
+        self::stripPrefixes($merged);
 
         return $merged;
     }
@@ -111,7 +111,7 @@ private function getSparqlUrl(Wiki $wiki): string {
 
     private static function stripPrefixes(array &$items): void {
         foreach ($items as &$item) {
-            $e = explode(':', $item);
+            $e = explode(':', (string) $item);
             $item = end($e);
         }
     }

app/Console/Kernel.php

@@ -24,6 +24,7 @@ class Kernel extends ConsoleKernel {
     /**
      * Define the application's command schedule.
      */
+    #[\Override]
     protected function schedule(Schedule $schedule): void {
         // Make sure that the DB and QS pools are always populated somewhat.
         // This will create at most 1 new entry for each per minute...
@@ -66,6 +67,7 @@ protected function schedule(Schedule $schedule): void {
     /**
      * Register the commands for the application.
      */
+    #[\Override]
     protected function commands(): void {
         $this->load(__DIR__ . '/Commands');
         $this->load(__DIR__ . '/Commands/User');

app/Exceptions/Handler.php

@@ -20,6 +20,7 @@ class Handler extends ExceptionHandler {
     /**
      * Register the exception handling callbacks for the application.
      */
+    #[\Override]
     public function register(): void {
         $this->reportable(function (Throwable $e): void {
             (new ErrorReporting)->report($e);

app/Helper/DomainValidator.php

@@ -6,13 +6,8 @@
 use Illuminate\Support\Facades\Validator;
 
 class DomainValidator {
-    public array $subdomainRules;
-
-    public string $subDomainSuffix;
-
-    public function __construct(string $subDomainSuffix, array $subdomainRules) {
-        $this->subDomainSuffix = $subDomainSuffix;
-        $this->subdomainRules = $subdomainRules;
+    public function __construct(public string $subDomainSuffix, public array $subdomainRules)
+    {
     }
 
     public function getValidator($domain): \Illuminate\Contracts\Validation\Validator {

app/Helper/ElasticSearchHelper.php

@@ -5,13 +5,8 @@
 use App\Http\Curl\HttpRequest;
 
 class ElasticSearchHelper {
-    private $elasticSearchHost;
-
-    private $elasticSearchBaseName;
-
-    public function __construct(string $elasticSearchHost, string $elasticSearchBaseName) {
-        $this->elasticSearchHost = $elasticSearchHost;
-        $this->elasticSearchBaseName = $elasticSearchBaseName;
+    public function __construct(private readonly string $elasticSearchHost, private readonly string $elasticSearchBaseName)
+    {
     }
 
     public function hasIndices(HttpRequest $request): bool {
@@ -44,7 +39,7 @@ public function hasIndices(HttpRequest $request): bool {
         // index\n
         // site1.localhost_content_blabla\n
         // site1.localhost_general_bla\n
-        $wikiIndices = array_filter(explode("\n", $rawResponse));
+        $wikiIndices = array_filter(explode("\n", (string) $rawResponse));
 
         // no indices to delete only index header
         if (count($wikiIndices) <= 1) {

app/Helper/InviteHelper.php

@@ -3,23 +3,17 @@
 namespace App\Helper;
 
 class InviteHelper {
-    private $segments;
-
-    private $segmentLength;
-
     private $prefix;
 
-    public function __construct(int $numSegments = 2, int $segmentLength = 4) {
+    public function __construct(private readonly int $segments = 2, private readonly int $segmentLength = 4) {
         $this->prefix = 'wbcloud-';
-        $this->segments = $numSegments;
-        $this->segmentLength = $segmentLength;
     }
 
     private function generateSegment(int &$counter): string {
         $segment = '';
 
         for ($i = 0; $i < $this->segmentLength; $i++) {
-            $segment .= rand(0, 9);
+            $segment .= random_int(0, 9);
         }
 
         $counter++;

app/Helper/MWTimestampHelper.php

@@ -12,7 +12,7 @@
 use Carbon\Exceptions\InvalidFormatException;
 
 class MWTimestampHelper {
-    private const MWTimestampFormat = 'YmdHis';
+    private const string MWTimestampFormat = 'YmdHis';
 
     public static function getCarbonFromMWTimestamp(string $MWTimestamp): CarbonImmutable {
         $carbon = CarbonImmutable::createFromFormat(self::MWTimestampFormat, $MWTimestamp);