Anonymize user email in disable command (#999)

There is a unique constraint on the user email column, meaning an empty string won't work for disabling subsequent users

Bug: T409908

Author: outdooracorn

app/Console/Commands/User/Disable.php

@@ -51,7 +51,7 @@ public function handle(): int {
         }
 
         $userId = $user->id;
-        $user->email = '';
+        $user->email = uniqid() . '@disabled-user.wikibase.cloud';
         $user->password = random_bytes(10);
         $user->verified = false;
 

tests/Commands/User/DisableTest.php

@@ -23,19 +23,22 @@ private function createUser($email) {
 
     public function testSuccess() {
         $oldUser = $this->createUser(self::EMAIL);
-        $oldUserId = $oldUser->id;
 
         $this->artisan('wbs-user:disable',
             [
                 '--email' => self::EMAIL,
             ]
         )->assertExitCode(0);
 
-        $newUser = User::firstWhere('id', $oldUserId);
+        $newUser = User::firstWhere('id', $oldUser->id);
 
         $this->assertSame($oldUser->id, $newUser->id);
-        $this->assertSame($newUser->email, '');
+        $this->assertMatchesRegularExpression(
+            '/^[0-9A-Za-z]+@disabled-user.wikibase.cloud$/',
+            $newUser->email
+        );
         $this->assertFalse($newUser->hasVerifiedEmail());
+        $this->assertNotSame($oldUser->password, $newUser->password);
     }
 
     public function testUserNotFound() {